Merged
Conversation
ofborg
bot
added
6.topic: haskell
peti
requested changes
Oct 11, 2019
Member
peti
left a comment
peti
left a comment
There was a problem hiding this comment.
Would you mind reporting this problem to upstream? It helps a lot, too, if you'd append a reference to that bug report in a comment in the source code before the override, so that it's easy for maintainers in the future to find out whether that issue still exists.
- Prometheus was failing due to the http-client version (0.6.4) being out-of-bounds (prometheus requires >=0.4 && <0.6). - However it builds fine when jailbroken, so I've just jailbroken it. - An issue has been submitted upstream on prometheus: bitnomial/prometheus#34
sevanspowell
force-pushed
the
haskell-updates
branch
from
1ec69e4 to
2cb0200
Compare
Contributor
Author
|
@peti Definitely! I see how that's helpful. Done. |
peti
approved these changes
Oct 13, 2019
sevanspowell
added a commit
to sevanspowell/nixpkgs
that referenced
this pull request
Oct 13, 2019
- Prometheus and ekg-prometheus-adapter were fixed in PR: NixOS#70956 but I forgot to remove them from the list of broken-packages.
peti
pushed a commit
that referenced
this pull request
Oct 18, 2019
- Prometheus and ekg-prometheus-adapter were fixed in PR: #70956 but I forgot to remove them from the list of broken-packages.
sevanspowell
added a commit
to sevanspowell/nixpkgs
that referenced
this pull request
Mar 19, 2020
- prometheus no longer needs to be jailbroken, removing 'doJailbreak'. Jailbreaking was added in NixOS#70956 to overcome issue bitnomial/prometheus#34. - This issue has since been fixed and so jailbreaking is no longer necessary.
10 tasks
sevanspowell
added a commit
to sevanspowell/nixpkgs
that referenced
this pull request
Mar 19, 2020
- prometheus no longer needs to be jailbroken, removing 'doJailbreak'. Jailbreaking was added in NixOS#70956 to overcome issue bitnomial/prometheus#34. - This issue has since been fixed and so jailbreaking is no longer necessary.
peti
pushed a commit
that referenced
this pull request
Mar 20, 2020
- prometheus no longer needs to be jailbroken, removing 'doJailbreak'. Jailbreaking was added in #70956 to overcome issue bitnomial/prometheus#34. - This issue has since been fixed and so jailbreaking is no longer necessary.
Janik-Haag
added
the
12.first-time contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
out-of-bounds (prometheus requires >=0.4 && <0.6).
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @peti @basvandijk @ElvishJerricco @vaibhavsagar