Skip to content

nixos/systemd: fix broken tmpfiles.d symlinks#70843

Merged
andir merged 1 commit intoNixOS:masterfrom
B4dM4n:systemd-tmpfiles
Oct 9, 2019
Merged

nixos/systemd: fix broken tmpfiles.d symlinks#70843
andir merged 1 commit intoNixOS:masterfrom
B4dM4n:systemd-tmpfiles

Conversation

@B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Oct 9, 2019

Motivation for this change

Some of the tmpfiles added in #69295 are broken due to a name typo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Oct 9, 2019
andir
andir approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@andir andir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you! 👍

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 9, 2019
@andir andir merged commit 633baf4 into NixOS:master Oct 9, 2019
@andir
Copy link
Member

andir commented Oct 9, 2019

Backported in 88bbb3c

@B4dM4n B4dM4n deleted the systemd-tmpfiles branch October 9, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andir andir andir approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@B4dM4n @andir