Skip to content

haskellPackages: unbreak cachix, hnix, hnix-store-remote#68272

Merged
peti merged 3 commits intoNixOS:haskell-updatesfrom
marsam:unbreak-cachix
Sep 7, 2019
Merged

haskellPackages: unbreak cachix, hnix, hnix-store-remote#68272
peti merged 3 commits intoNixOS:haskell-updatesfrom
marsam:unbreak-cachix

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Sep 7, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam marsam requested a review from basvandijk as a code owner September 7, 2019 16:01
@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 7, 2019
@teto
Copy link
Member

teto commented Sep 7, 2019

There is still a broken = true; for cachix in hackage-packages.nix

@teto
Copy link
Member

teto commented Sep 7, 2019

arf even if I remove that line, then I end up with

Building library for cachix-0.3.0..
[ 1 of 18] Compiling Cachix.Client.Config.Orphans ( src/Cachix/Client/Config/Orphans.hs, dist/build/Cachix/Client/Config/Orphans.o )
[ 2 of 18] Compiling Cachix.Client.Config ( src/Cachix/Client/Config.hs, dist/build/Cachix/Client/Config.o )
[ 3 of 18] Compiling Cachix.Client.Exception ( src/Cachix/Client/Exception.hs, dist/build/Cachix/Client/Exception.o )
[ 4 of 18] Compiling Cachix.Client.NetRc ( src/Cachix/Client/NetRc.hs, dist/build/Cachix/Client/NetRc.o )
[ 5 of 18] Compiling Cachix.Client.NixConf ( src/Cachix/Client/NixConf.hs, dist/build/Cachix/Client/NixConf.o )
[ 6 of 18] Compiling Cachix.Client.InstallationMode ( src/Cachix/Client/InstallationMode.hs, dist/build/Cachix/Client/InstallationMode.o )
[ 7 of 18] Compiling Cachix.Client.NixVersion ( src/Cachix/Client/NixVersion.hs, dist/build/Cachix/Client/NixVersion.o )
[ 8 of 18] Compiling Cachix.Client.Secrets ( src/Cachix/Client/Secrets.hs, dist/build/Cachix/Client/Secrets.o )
[ 9 of 18] Compiling Cachix.Client.Store.Context ( src/Cachix/Client/Store/Context.hs, dist/build/Cachix/Client/Store/Context.o )
[10 of 18] Compiling Cachix.Client.Store ( src/Cachix/Client/Store.hs, dist/build/Cachix/Client/Store.o )

In file included from /nix/store/k4ldd0sadcin0hcvmmpfm1xzfc4j2nyv-nix-2.3-dev/include/nix/util.hh:3:0: error:
    0,
                     from /nix/store/k4ldd0sadcin0hcvmmpfm1xzfc4j2nyv-nix-2.3-dev/include/nix/shared.hh:3,
                     from /build/ghc10822_0/ghc_55.cpp:6:

/nix/store/k4ldd0sadcin0hcvmmpfm1xzfc4j2nyv-nix-2.3-dev/include/nix/types.hh:12:10: error:
     fatal error: boost/format.hpp: No such file or directory
     #include <boost/format.hpp>
              ^~~~~~~~~~~~~~~~~~
   |
12 | #include <boost/format.hpp>
   |          ^

feels like cachix is often broken on unstable sadly :(

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Sep 7, 2019

@teto I think that should be left there. ping @peti

@marsam
Copy link
Contributor Author

marsam commented Sep 7, 2019

@teto IIUC generally editing hackage-packages.nix should be avoided #67438 (comment).
About the build, that is weird, I can build it on Darwin and NixOS. Do you perhaps had overrided nix with nixUnstable?

@teto
Copy link
Member

teto commented Sep 7, 2019

you are right, I should get some sleep :) How do you test then ? I wish we could run an update from nixpkgs without setting up another repo (see #62105), otherwise it makes contributing harder. And nix-review doesn't work since it doesn't detect a change.
It's possible something interfered in my end results, since I have a few things in the overlay but I was using this PR with nix 2.2.2 and my overlay.

@peti peti merged this pull request into NixOS:haskell-updates Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants