Skip to content

nvidia_x11: 430.40 -> 435.21#67762

Merged
veprbl merged 1 commit intoNixOS:masterfrom
eadwu:nvidia_x11/435.21
Aug 31, 2019
Merged

nvidia_x11: 430.40 -> 435.21#67762
veprbl merged 1 commit intoNixOS:masterfrom
eadwu:nvidia_x11/435.21

Conversation

@eadwu
Copy link
Member

@eadwu eadwu commented Aug 30, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@eadwu eadwu mentioned this pull request Aug 30, 2019
Closed
10 tasks
@eadwu
Copy link
Member Author

eadwu commented Aug 30, 2019

The DPMS issue is fixed on this version so offloading should work perfectly now, see #66601 for implementation.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 30, 2019
ivan
ivan approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@ivan ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not see any regressions after testing a bunch of GL-using programs on NixOS x86_64 / Linux 4.19.69-hardened / 1050 Ti

@ivan
Copy link
Member

ivan commented Aug 31, 2019

cc maintainer @baracoder

@veprbl veprbl merged commit 12e2486 into NixOS:master Aug 31, 2019
@veprbl
Copy link
Member

veprbl commented Aug 31, 2019

@eadwu @ivan Thank you!

@ghost ghost mentioned this pull request Sep 1, 2019
Merged
10 tasks
@primeos primeos mentioned this pull request Sep 3, 2019
Closed
@eadwu eadwu deleted the nvidia_x11/435.21 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ivan ivan ivan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eadwu @ivan @veprbl