Skip to content

cc-wrapper: Set default system include flags for non-gcc c++ on Linux#6688

Merged
shlevy merged 1 commit intoNixOS:stagingfrom
shlevy:cc-wrapper-clang-libstdcxx
Mar 7, 2015
Merged

cc-wrapper: Set default system include flags for non-gcc c++ on Linux#6688
shlevy merged 1 commit intoNixOS:stagingfrom
shlevy:cc-wrapper-clang-libstdcxx

Conversation

@shlevy
Copy link
Member

@shlevy shlevy commented Mar 6, 2015

Without this, clang can't find libstdc++. This needs to happen in the wrapper
so that the libc++ setup hook can still override it

Without this, clang can't find libstdc++. This needs to happen in the wrapper
so that the libc++ setup hook can still override it
@shlevy
Copy link
Member Author

shlevy commented Mar 6, 2015

cc @edolstra @Ralith

@peti peti added 0.kind: bug Something is broken mass-rebuild labels Mar 6, 2015
@shlevy shlevy mentioned this pull request Mar 6, 2015
@shlevy shlevy merged commit f91dea4 into NixOS:staging Mar 7, 2015
@eddyb
Copy link
Contributor

eddyb commented May 22, 2015

This broke ccache-links-wrapper - how could such breakage have been overlooked?
The generated line is:

NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE ${NIX_CXXSTDLIB_COMPILE--isystem  -isystem /x86_64-unknown-linux-gnu}"

@eddyb eddyb mentioned this pull request Jul 30, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: bug Something is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants