Skip to content

gitlab-ce: 12.0.3 -> 12.1.6#66621

Merged
flokli merged 5 commits intoNixOS:masterfrom
flokli:gitlab-12.1.6
Aug 18, 2019
Merged

gitlab-ce: 12.0.3 -> 12.1.6#66621
flokli merged 5 commits intoNixOS:masterfrom
flokli:gitlab-12.1.6

Conversation

@flokli
Copy link
Member

@flokli flokli commented Aug 14, 2019

This bumps gitlab to its latest version (12.1.6), also containing some important security fixes.
On top of that, we stop shipping the 1.3GiB gitlab-deb-data.tar file in $out ;-)

Motivation for this change

https://about.gitlab.com/2019/08/12/critical-security-release-gitlab-12-dot-1-dot-6-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lheckemann @talyz

flokli added 4 commits August 14, 2019 14:45
There's no reason to ship a 1.6GiB .tar file in the output.
Slims down that output from 1.9GiB to ~350MiB
@flokli flokli requested review from fpletz and globin August 14, 2019 12:59
@flokli flokli mentioned this pull request Aug 14, 2019
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 14, 2019
@flokli flokli mentioned this pull request Aug 14, 2019
10 tasks
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Aug 14, 2019
@flokli flokli added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 14, 2019
@adisbladis
Copy link
Member

@GrahamcOfBorg test gitlab

@mmahut
Copy link
Member

mmahut commented Aug 17, 2019

@GrahamcOfBorg build gitlab gitaly gitlab-ee

@flokli flokli merged commit 36ece76 into NixOS:master Aug 18, 2019
@flokli flokli deleted the gitlab-12.1.6 branch August 18, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants