kernel/modules-closure.sh: fix the modules closure

[xaverdh]

Prior to this commit the modules closure could reference nonsensical
pieces of data in to form of module parameters. These were treated as
separate modules.

Motivation for this change

resolving #57421

Things done

I tested this on my own device, but since this touches a core part, it should probably get some real testing.

[infinisil]

Can you add a comment in the code explaining what that regex does? And the commit message could explain why the change was necessary and e.g. what new parts the regex doesn't include/newly includes.

[xaverdh]

Should I include a reference to the source at kernel.org in the commit message?

[xaverdh]

Also I had to touch that line some more, to place the comment somewhere sane. While doing that, I noticed, that I don't understand how the exit status test is supposed to work (even in the original version). I think its supposed to cover the case where modprobe exists with nonzero exit status, but that will get swallowed by the pipe.

[xaverdh]

I opened a separate pr which should fix the check for missing modules as well.

[xaverdh]

Ping
Is there something more I should do?
Would be cool to get one of these prs merged.

[infinisil]

Looks good to me, though I haven't tested it. How does this PR compare to the other one?

[xaverdh]

The second one

Also fixes a bug in the original implementation where the check for missing modules did not work as indended (the exit status of
modprobe was ignored due to a pipe).

[stale]

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
2. Ask on the NixOS Discourse.
3. Ask on the #nixos channel on irc.freenode.net.

[xaverdh]

closed in favour of #92081