Skip to content

hcloud: 1.11.0 -> 1.13.0#65599

Merged
srhb merged 2 commits intoNixOS:masterfrom
elmarx:hcloud-1.13.0
Aug 3, 2019
Merged

hcloud: 1.11.0 -> 1.13.0#65599
srhb merged 2 commits intoNixOS:masterfrom
elmarx:hcloud-1.13.0

Conversation

@elmarx
Copy link
Member

@elmarx elmarx commented Jul 30, 2019

Motivation for this change

Update hcloud v1.11.0 to v1.13.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@petabyteboy already created a PR for 1.11.0 -> 1.12.0 which did not yet get merged, but is somehow superseeded by the update to 1.13.0

@ghost ghost mentioned this pull request Jul 30, 2019
10 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 30, 2019
@ghost
Copy link

ghost commented Jul 30, 2019

Built and ran resulting binary 👍
Closure size increased from 38.9M to 39.3M, which seems fine for this update

@ghost
Copy link

ghost commented Jul 30, 2019

If you like you can add quotes to the homepage (NixOS/rfcs#45) and change name = "hcloud-${version}"; to pname = "hcloud"; (NixOS/rfcs#35).

This implements rfc 0035 and rfc 0045.
@elmarx
Copy link
Member Author

elmarx commented Jul 30, 2019

Ah great, I didn't know about these, thanks for the info! I implemented the changes you proposed :)

Copy link
Member

@angristan angristan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successful build and run:

[nix-shell:~/.cache/nix-review/pr-65599]$ hcloud version
hcloud 1.13.0

@srhb srhb merged commit 33c3c22 into NixOS:master Aug 3, 2019
@elmarx elmarx deleted the hcloud-1.13.0 branch April 25, 2023 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants