Merged
Conversation
|
Built and ran resulting binary 👍 |
|
If you like you can add quotes to the homepage (NixOS/rfcs#45) and change |
This implements rfc 0035 and rfc 0045.
Member
Author
|
Ah great, I didn't know about these, thanks for the info! I implemented the changes you proposed :) |
angristan
approved these changes
Aug 1, 2019
Member
angristan
left a comment
There was a problem hiding this comment.
Successful build and run:
[nix-shell:~/.cache/nix-review/pr-65599]$ hcloud version
hcloud 1.13.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update hcloud v1.11.0 to v1.13.0
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
@petabyteboy already created a PR for 1.11.0 -> 1.12.0 which did not yet get merged, but is somehow superseeded by the update to 1.13.0