Merged
Conversation
Member
|
@GrahamcOfBorg build bazel.tests |
Contributor
Author
|
I dont understand the failure in |
Member
|
@GrahamcOfBorg eval |
Member
|
@guibou it was an unrelated issue on master which has been resolved |
Contributor
Author
|
@Profpatsch suggested that I used an import from derivation which may be forbidden in nixpkgs. Is that true ? |
Member
|
Ah, there is indeed something else. I just thought, without really looking it, it was the same as the other PR's. |
Member
|
Indeed, you are using import from derivation: |
--distdir is now used in the installCheckPhase for prefetched repositories. That's simpler, more robust and easier to extend in the future. Note that `name` argument of fetchurl was removed because it changed the basename of the generated file and bazel uses this basename for its cache behavior.
Contributor
Author
|
I removed the import from derivation refactoring. Sorry I was not aware that it was not allowed in nixpkgs. |
ofborg
bot
added
10.rebuild-darwin: 1-10
Member
|
@GrahamcOfBorg build bazel bazel.tests |
Member
|
@guibou looks like the update broke the protocol buffer test on Darwin. |
Contributor
Author
|
@kalbasit test for tentative fix in progress. @GrahamcOfBorg build bazel bazel.tests (I'm not sure @GrahamcOfBorg is obeying me, so if you have more control over him, please run the tests) |
Member
|
@GrahamcOfBorg build bazel bazel.tests |
Contributor
Author
|
Any darwin user can help me to fix the build failure. I don't have access to a darwin machine. |
Member
|
@guibou would an ssh connection help you? |
Contributor
Author
|
Yes, definitely.
…On Sun, Jul 14, 2019 at 10:23 PM Wael Nasreddine ***@***.***> wrote:
@guibou <https://github.com/guibou> would an ssh connection help you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#64633?email_source=notifications&email_token=ACKBPDLRUVEDGYFKZWSLD5LP7ODNZA5CNFSM4IBKRKA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4MUTI#issuecomment-511232589>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACKBPDIUIGSM4XB7CJRDBZ3P7ODNZANCNFSM4IBKRKAQ>
.
|
Member
Ok let's continue this discussion on Keybase, I'm @YLCodes over there. I'll get my mac ready in the meantime. |
Member
I'm ready whenever you are! |
Contributor
|
I tested this branch as it is now (320dd2def24e6dacd1d6b89b6fa705169d10bc43) on my mac and it's working. |
10 tasks
Member
|
@uri-canva can you try on your mac to build |
Contributor
|
Yep, output |
Contributor
|
The ofborg darwin environment is a bit strange, it's not the same as a regular macOS nix installation, either with or without sandboxing enabled, or the hydra environment. I've hit issues with it before but I could never reproduce them, eventually I think we merged ignoring the ofborg results, and it worked fine on hydra. @groodt do you remember something more about that? |
Contributor
Author
|
I've squashed my "fixup" commit to clean a bit my history. Considering that @GrahamcOfBorg is unhappy about |
Member
It's not the best option to merging with an unhappy build. Perhaps @LnL7 or @grahamc may help here? I'm going to test on my Darwin as well. EDIT: It works on my Mac as well. 🤔 |
Member
|
@GrahamcOfBorg build bazel bazel.tests |
Member
|
ok ofborg says that it's passing now. |
kalbasit
approved these changes
Jul 16, 2019
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Bazel bump to 0.28. I also refactored the following:
--distdir, which removes a lot of boilerplate.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)