Skip to content

node-packages-v10: add sass cli program#64566

Closed
proger wants to merge 2 commits intoNixOS:masterfrom
proger:nodePackages-sass
Closed

node-packages-v10: add sass cli program#64566
proger wants to merge 2 commits intoNixOS:masterfrom
proger:nodePackages-sass

Conversation

@proger
Copy link
Contributor

@proger proger commented Jul 10, 2019

Adding nodePackages.sass which is a popular css preprocessor CLI according to node section of nixpkgs manual. Includes a regen commit.

Checklist (i consider unchecked as inapplicable):

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 10, 2019
@mattmelling
Copy link
Contributor

This builds fine and works for me, but I get the following building under nix-review:

$ nix-review  pr 64566
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/64566/head:refs/nix-review/1
remote: Enumerating objects: 6, done.
remote: Counting objects: 100% (6/6), done.
remote: Compressing objects: 100% (2/2), done.
remote: Total 6 (delta 4), reused 6 (delta 4), pack-reused 0
Unpacking objects: 100% (6/6), done.
From https://github.com/NixOS/nixpkgs
   263b5244efd..23a51a61d8e  master     -> refs/nix-review/0
$ git worktree add /home/matt/.cache/nix-review/pr-64566-2/nixpkgs 23a51a61d8ea5c56d2f108bbb04ac7a2409ab58a
Preparing worktree (detached HEAD 23a51a61d8e)
HEAD is now at 23a51a61d8e vimPlugins: update (#64696)
$ git merge --no-commit 7178a4b14518b0fcee47ae2562595aa26dc4b8f9
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 8 --option build-use-sandbox true -f /home/matt/.cache/nix-review/pr-64566-2/build.nix
builder for '/nix/store/4a40gd2s35aczg7kkf16hmjz9sb6l27d-meguca-unstable-2019-03-12.drv' failed with exit code 2; last 10 log lines:
  github.com/bakape/meguca/templates
  github.com/bakape/meguca/db
  github.com/bakape/meguca/geoip
  github.com/bakape/meguca/cache
  github.com/bakape/meguca/parser
  github.com/bakape/meguca/imager
  github.com/bakape/meguca/websockets/feeds
  github.com/bakape/meguca/websockets
  github.com/bakape/meguca/server
  github.com/bakape/meguca
cannot build derivation '/nix/store/2wmq524fnvx7fy68sk0kpzrvgx1vclma-env.drv': 1 dependencies couldn't be built
[0 built (1 failed)]
error: build of '/nix/store/2wmq524fnvx7fy68sk0kpzrvgx1vclma-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/64566
2 package are marked as broken and were skipped:
casperjs facette

1 package failed to build:
meguca

15 package were build:
azure-cli create-cycle-app fast-cli joplin lessc lumo npm2nix python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.oauthenticator shout sloc styx triton wasm-text-gen

@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@prusnak prusnak added 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels May 30, 2020
@ryantm ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020
@ryantm
Copy link
Member

ryantm commented Oct 16, 2020

merged via #100606

@ryantm ryantm closed this Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants