Skip to content

installation-device.nix: explain sshd usage, don't include clone-config#63773

Merged
flokli merged 4 commits intoNixOS:masterfrom
flokli:installation-device-fixes
Aug 31, 2019
Merged

installation-device.nix: explain sshd usage, don't include clone-config#63773
flokli merged 4 commits intoNixOS:masterfrom
flokli:installation-device-fixes

Conversation

@flokli
Copy link
Member

@flokli flokli commented Jun 25, 2019 •
edited
Loading

Motivation for this change

The configuration used to build an installation medium isn't really
suitable to be (re)used when building a real system.

For example, it enables automatic root login without a password on the
console, installs sshd, but prevents it from starting on boot.

This can be very misleading when users try to derive their real system
from it - they should use nixos-generate-config instead, as described in
the manual.

Also update the mingetty helpLine to describe the sshd setup.

Closes #63576
Closes #26776

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from samueldr June 25, 2019 14:24
@flokli
Copy link
Member Author

flokli commented Jun 25, 2019

@GrahamcOfBorg test installer

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 25, 2019
@samueldr

This comment has been minimized.

Sign in to view
samueldr
samueldr suggested changes Jun 26, 2019
View reviewed changes
@flokli flokli mentioned this pull request Jun 29, 2019
Closed
@flokli flokli force-pushed the installation-device-fixes branch from 302fa62 to 123bd39 Compare August 17, 2019 21:59
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. and removed 8.has: documentation This PR adds or changes documentation labels Aug 17, 2019
@flokli flokli mentioned this pull request Aug 17, 2019
Merged
10 tasks
@ofborg ofborg bot added the 8.has: documentation This PR adds or changes documentation label Aug 17, 2019
@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 17, 2019

Oh, missed the profiles documentation because I don't think I noticed when this was added.

worldofpeace
worldofpeace reviewed Aug 17, 2019
View reviewed changes
worldofpeace
worldofpeace reviewed Aug 17, 2019
View reviewed changes
worldofpeace
worldofpeace reviewed Aug 17, 2019
View reviewed changes
worldofpeace
worldofpeace reviewed Aug 17, 2019
View reviewed changes
@flokli flokli force-pushed the installation-device-fixes branch from 3e68d93 to 3509d85 Compare August 17, 2019 23:43
worldofpeace
worldofpeace reviewed Aug 17, 2019
View reviewed changes
worldofpeace
worldofpeace reviewed Aug 17, 2019
View reviewed changes
worldofpeace
worldofpeace reviewed Aug 17, 2019
View reviewed changes
@flokli flokli force-pushed the installation-device-fixes branch from 3509d85 to 7d2c552 Compare August 18, 2019 00:01
worldofpeace
worldofpeace reviewed Aug 18, 2019
View reviewed changes
worldofpeace
worldofpeace reviewed Aug 18, 2019
View reviewed changes
worldofpeace
worldofpeace reviewed Aug 18, 2019
View reviewed changes
@flokli flokli force-pushed the installation-device-fixes branch 2 times, most recently from 5669c04 to cfb4a12 Compare August 18, 2019 00:09
worldofpeace
worldofpeace approved these changes Aug 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs seem good 👍

@flokli
Copy link
Member Author

flokli commented Aug 18, 2019

@samueldr, could you give this a try once sd_image builds again?

@worldofpeace
Copy link
Contributor

worldofpeace commented Aug 18, 2019

Probably immediately easy enough to revert #63835 for the image

flokli added 4 commits August 19, 2019 16:34
@flokli
nixos/installation-device.nix: explain sshd usage
f71fd79
@flokli
sd-image.nix: set installer.cloneConfig to false
0aa5e31 
As SD Card images are both installation media and installation target,
don't copy over a /etc/nixos/configuration.nix

Closes NixOS#63576.
@flokli
nixos/doc: update installation-device.nix
1515afe 
This got quite outdated. We now have both the nixos and root user
available for example.
@flokli
nixos/doc/clone-config.xml: add line about installation media = insta…
d6eb5b0 
…llation target
@flokli flokli force-pushed the installation-device-fixes branch from cfb4a12 to d6eb5b0 Compare August 19, 2019 14:34
@flokli
Copy link
Member Author

flokli commented Aug 19, 2019

Rebased on top of master, as #66850 landed.

@flokli flokli merged commit 4e586de into NixOS:master Aug 31, 2019
@flokli flokli deleted the installation-device-fixes branch August 31, 2019 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@samueldr samueldr samueldr requested changes

@worldofpeace worldofpeace worldofpeace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sd-image-aarch64 shouldn't import profiles/installation-device.nix SSHD doesn't work.

3 participants

@flokli @samueldr @worldofpeace