Skip to content

libtensorflow: 1.9.0 -> 1.13.1#63114

Closed
kuznero wants to merge 1 commit intoNixOS:masterfrom
kuznero:tensorflow
Closed

libtensorflow: 1.9.0 -> 1.13.1#63114
kuznero wants to merge 1 commit intoNixOS:masterfrom
kuznero:tensorflow

Conversation

@kuznero
Copy link
Member

@kuznero kuznero commented Jun 14, 2019

Motivation for this change

Update libtensorflow to latest stable version 1.13.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kuznero
Copy link
Member Author

kuznero commented Jun 14, 2019

Ping @basvandijk, please review

@kuznero
Copy link
Member Author

kuznero commented Jun 14, 2019

I will still need to test if all dependencies are in place when built with CUDA support (later today). So far, I noticed that when built with GPU support, ldd shows that some of the dependencies cannot be found in cuda* space. Not sure if that is how it was before.

@ofborg ofborg bot requested a review from basvandijk June 14, 2019 08:49
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 14, 2019
@FRidh
Copy link
Member

FRidh commented Jun 16, 2019

Closing in favor of #63208

@FRidh FRidh closed this Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants