WIP: improve support for crosscompiling to musl32 by wfranzini · Pull Request #62817 · NixOS/nixpkgs

wfranzini · 2019-06-07T08:28:13Z

Motivation for this change

Crosscompiling packages to musl32 lead to compilation errors due to the missing __stack_chk_fail_local symbol. Even building nix fails. This PR disable stackprotector for musl32.

Things done

The makefile patch pulled from alpinelinux used to enable stackprotector unconditionally. This change use the nixpkgs flag hardeningEnable. This is required to support platform where stackprotector has problems.

nixos-discourse · 2019-06-07T09:25:53Z

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/crosscompilation-to-musl32-problems/3110/5

The patches from alpinelinux failed to apply to v2.8.5, on the other hand upstream has added support for musl based system in the master branch on github [1]. The patch has been added to the nixpkgs repo since it needs to be modified slightly, a copyright notice has been removed, to apply cleanly. 1. linux-audit/audit-userspace@d579a08

pkgs/build-support/cc-wrapper/default.nix

Without this change crosscompiling fails because perl is not found during configure.

Disable the pipe rewind related feature since musl has no support for it.

matthewbauer · 2019-06-07T19:48:24Z

pkgs/development/libraries/libexecinfo/default.nix

-      url = https://git.alpinelinux.org/cgit/aports/plain/main/libexecinfo/30-linux-makefile.patch?id=730cdcef6901750f4029d4c3b8639ce02ee3ead1;
-      sha256 = "1jwjz22z5cjy5h2bfghn62yl9ar8jiqhdvbwrcfavv17ihbhwcaf";
-    })
+    ./30-linux-makefile.patch


I wonder if alpine has a way to get ssp working?

@matthewbauer Alpinelinux creates a small libssp_nonshared library in the musl-dev package.
https://git.alpinelinux.org/aports/tree/main/musl?h=master

I've recreated it in my local nixpkgs repo, however I'm not sure how to automatically link with libssp_nonshared.a.

Do you have a hint?

You probably need to put it in musl's $out/lib/libssp_nonshared.a. Unfortunately we also need to apply this patch to GCC:

https://git.alpinelinux.org/aports/tree/main/gcc/gcc-6.1-musl-libssp.patch

That would probably be okay to apply to GCC, but maybe only on i686-musl builds.

7c6f434c · 2019-08-22T20:03:42Z

For context: is this problem irrelevant in 64-bit case?

matthewbauer · 2019-08-22T20:16:17Z

For context: is this problem irrelevant in 64-bit case?

I have never seen it on x86_64. I think it could be possible to hit it with some messy linking, but I would prefer to limit the patching to just i*86 for now.

In order to support stackprotector on musl32, this change import a couple of patches from alpinelinux: 1. libssp_nonshared.a is built alongside musl's libc 2. the above library is automatically linked when compiling with gcc6 or gcc7

symphorien · 2019-11-06T20:47:12Z

I successfully used this PR to compile openssl.

Ericson2314 · 2019-11-07T18:21:06Z

Can we submit some of these patches upstream and fetchpatch them?

wfranzini · 2019-11-08T14:24:08Z

Can we submit some of these patches upstream and fetchpatch them?

@Ericson2314 I'll look into this the next week.

I would like to have this PR merged somewhere in the future, but I need guidance about the correct branch to use since I fear it will cause a massive rebuild.

flokli · 2019-11-08T14:52:02Z

@wfranzini this should target the staging branch.

stale · 2020-06-01T05:24:04Z

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the
related code and @ mention them in a comment.
Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
irc.freenode.net.

symphorien · 2020-06-01T08:32:50Z

I would really like to see this merged in one form or another.

7c6f434c · 2020-06-03T23:32:35Z

pkgs/os-specific/linux/audit/audit-strndupa-rawmemchr-compat.patch

+From d579a08bb1cde71f939c13ac6b2261052ae9f77e Mon Sep 17 00:00:00 2001
+From: Steve Grubb <sgrubb@redhat.com>
+Date: Tue, 26 Feb 2019 18:33:33 -0500
+Subject: [PATCH] Add substitue functions for strndupa & rawmemchr


Suggested change

Subject: [PATCH] Add substitue functions for strndupa & rawmemchr

Subject: [PATCH] Add substitute functions for strndupa & rawmemchr

wfranzini · 2020-06-04T07:14:37Z

Later today, I'm going to open a new PR starting from staging.

wfranzini · 2020-06-04T10:37:35Z

I'll continue working on the cross compilation to musl32 in PR #89471

wfranzini added 2 commits June 7, 2019 10:07

disable stackprotector on target platform musl32

db5d5e2

libexecinfo: enables stackprotector through hardeningEnable

ee2ad96

The makefile patch pulled from alpinelinux used to enable stackprotector unconditionally. This change use the nixpkgs flag hardeningEnable. This is required to support platform where stackprotector has problems.

wfranzini requested a review from Ericson2314 as a code owner June 7, 2019 08:28

libsodium: disable stackprotector on musl32

533dcc7

ofborg bot requested review from 7c6f434c, Fuuzetsu and dtzWill June 7, 2019 12:35

flokli reviewed Jun 7, 2019

View reviewed changes

pkgs/build-support/cc-wrapper/default.nix Outdated Show resolved Hide resolved

bison2: add perl in nativeBuildInputs

63762fc

Without this change crosscompiling fails because perl is not found during configure.

sox: musl does not support pipe rewind

b509a5f

Disable the pipe rewind related feature since musl has no support for it.

matthewbauer reviewed Jun 7, 2019

View reviewed changes

identify musl32 using x86_32 instead of i686

c6ecd1a

FRidh added the 2.status: work-in-progress label Jul 17, 2019

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Aug 23, 2019

add stackprotector support on musl32

8b7219b

In order to support stackprotector on musl32, this change import a couple of patches from alpinelinux: 1. libssp_nonshared.a is built alongside musl's libc 2. the above library is automatically linked when compiling with gcc6 or gcc7

matthewbauer mentioned this pull request Aug 28, 2019

[wip] Statically built Nix #56281

Closed

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020

7c6f434c reviewed Jun 3, 2020

View reviewed changes

7c6f434c approved these changes Jun 4, 2020

View reviewed changes

wfranzini mentioned this pull request Jun 4, 2020

WIP: Cross compilation to musl32 support #89471

Closed

10 tasks

wfranzini closed this Jun 4, 2020

	Subject: [PATCH] Add substitue functions for strndupa & rawmemchr
	Subject: [PATCH] Add substitute functions for strndupa & rawmemchr

Uh oh!

Conversation

wfranzini commented Jun 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

nixos-discourse commented Jun 7, 2019

Uh oh!

Uh oh!

matthewbauer Jun 7, 2019

Choose a reason for hiding this comment

Uh oh!

wfranzini Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

matthewbauer Aug 21, 2019

Choose a reason for hiding this comment

Uh oh!

7c6f434c commented Aug 22, 2019

Uh oh!

matthewbauer commented Aug 22, 2019

Uh oh!

symphorien commented Nov 6, 2019

Uh oh!

Ericson2314 commented Nov 7, 2019

Uh oh!

wfranzini commented Nov 8, 2019

Uh oh!

flokli commented Nov 8, 2019

Uh oh!

stale bot commented Jun 1, 2020

Uh oh!

symphorien commented Jun 1, 2020

Uh oh!

7c6f434c Jun 3, 2020

Choose a reason for hiding this comment

Uh oh!

wfranzini commented Jun 4, 2020

Uh oh!

wfranzini commented Jun 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

wfranzini commented Jun 7, 2019 •

edited

Loading