mpssh: init at 1.3.3

[ktf]

Motivation for this change

New package.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[mmahut]

Few cosmetic suggestions, other it works as expected.

• reviewed the diff and commit messages
• made sure ofBorg eval
• run nix-review without any failures
• run and tested the binaries

[ktf]

Fixed as suggested. Thank you for the prompt review.

[ktf]

I think I've addressed all the comments. New commit force pushed.

[jtojnar]

You can use "BIN=${placeholder "out"}/bin" in makeFlags.

https://github.com/ndenev/mpssh/blob/6c577ee51e9ec7196c8ddc34768baeba317af8b5/Makefile#L8

[jtojnar]

Perhaps use a patch, it will make it easier to notice when the substitution no longer applies

patches = [
  # Do not install as root
  (fetchpatch {
    url = https://github.com/ndenev/mpssh/commit/3cbb868b6fdf8dff9ab86868510c0455ad1ec1b3.patch;
    sha256 = "0000000000000000000000000000000000000000000000000000000000000000";
  })
];

[jtojnar]

Please make this a list: #45886

[jtojnar]

It is usually nicer to use with stdenv.lib here, so that it does not need to be repeated in meta.

[mmahut]

Do you mind squashing your commits?

[aanderse]

@ktf are you able to address the above comments and continue with this PR?

[stale]

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

1. Search for maintainers and people that previously touched the
   related code and @ mention them in a comment.
2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
   irc.freenode.net.