Skip to content

katex: init at 0.10.2#61873

Closed
mt-caret wants to merge 1 commit intoNixOS:masterfrom
mt-caret:katex
Closed

katex: init at 0.10.2#61873
mt-caret wants to merge 1 commit intoNixOS:masterfrom
mt-caret:katex

Conversation

@mt-caret
Copy link
Contributor

Motivation for this change

Add katex, a program that accepts a subset of TeX math and converts it to HTML.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels May 22, 2019
@alexarice
Copy link
Contributor

nodePackages_10_x version works fine though there is no attribute for the nodePackages_8_x package (I'm assuming there should be one as a load of node v8 files have changed). I don't really know enough about js to review properly and I don't know how hard this would be to merge at this point

@ryantm ryantm added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2020
@veprbl
Copy link
Member

veprbl commented May 15, 2020

@mt-caret Do you still need katex to be included in nixpkgs?

@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@prusnak prusnak added the 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment label May 30, 2020
@mt-caret
Copy link
Contributor Author

@veprbl @prusnak Apologies for the late response. I'm no longer super interested in including this in nixpkgs, so I'm closing this PR.

@mt-caret mt-caret closed this May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants