Skip to content

vala updates#60548

Merged
worldofpeace merged 6 commits intoNixOS:stagingfrom
worldofpeace:vala-updates/04-30-19
May 1, 2019
Merged

vala updates#60548
worldofpeace merged 6 commits intoNixOS:stagingfrom
worldofpeace:vala-updates/04-30-19

Conversation

@worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Apr 30, 2019

Motivation for this change

See News in commit msg's.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from jtojnar and peterhoeg April 30, 2019 23:01
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 30, 2019
@jtojnar
Copy link
Member

jtojnar commented Apr 30, 2019

Myybe we should merge the Vala part of #60198 first.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented May 1, 2019

I'd like to pick 393ca4c here and then it can be dropped from that pr if that sounds reasonable?

@jtojnar
Copy link
Member

jtojnar commented May 1, 2019

Other than that 0.42 commit message links to 0.40 news

@worldofpeace worldofpeace force-pushed the vala-updates/04-30-19 branch from 49a5933 to 716e28b Compare May 1, 2019 01:53
worldofpeace and others added 2 commits April 30, 2019 21:55
@worldofpeace
vala: no vertical align
2148e70
@JohnAZoidberg @worldofpeace
vala: Prepare for updateScript
cbb8034 
It doesn't have to be that complicated with the major and minor versions
being split. We have library functions that handle it fine.

passthru.upateScript can be enabled once NixOS#59372 is merged
@worldofpeace worldofpeace force-pushed the vala-updates/04-30-19 branch from 716e28b to cbb8034 Compare May 1, 2019 01:55
@worldofpeace
Copy link
Contributor Author

worldofpeace commented May 1, 2019

Fixed the commit msg. Self merging 😄

@worldofpeace worldofpeace merged commit 018e5ff into NixOS:staging May 1, 2019
@worldofpeace worldofpeace deleted the vala-updates/04-30-19 branch May 1, 2019 01:56
@ofborg ofborg bot requested a review from jtojnar May 1, 2019 01:56
@worldofpeace worldofpeace mentioned this pull request May 1, 2019
Merged
10 tasks
@dtzWill
Copy link
Member

dtzWill commented May 3, 2019

AFAICT vala 0.44.3 on current staging doesn't build, because the graphviz patch fails to apply :(.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented May 3, 2019

Fix incoming shortly 👍

@worldofpeace
Copy link
Contributor Author

worldofpeace commented May 3, 2019

patch for vala 0.44.3 fixed in 3b481df

it was rejected because https://gitlab.gnome.org/GNOME/vala/commit/911973341ff70d6b6b00ce612d99e0aaf699106d

@dtzWill
Copy link
Member

dtzWill commented May 3, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@worldofpeace @jtojnar @dtzWill @JohnAZoidberg