Skip to content

ssh-audit: init at 1.7.0#60519

Merged
Lassulus merged 1 commit intoNixOS:masterfrom
4z3:ssh-audit
May 1, 2019
Merged

ssh-audit: init at 1.7.0#60519
Lassulus merged 1 commit intoNixOS:masterfrom
4z3:ssh-audit

Conversation

@4z3
Copy link
Contributor

@4z3 4z3 commented Apr 30, 2019 •
edited
Loading

Motivation for this change

ssh-audit is not packaged, yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 30, 2019
@Lassulus
Copy link
Member

Lassulus commented Apr 30, 2019

tested with nix-review and checked some configs via ssh-audit $hostname

tomberek
tomberek approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions on Ubuntu. No reverse dependencies.

aanderse
aanderse requested changes Apr 30, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few minor nitpicks.

@Lassulus Lassulus force-pushed the ssh-audit branch 2 times, most recently from d5094dc to fff80ba Compare April 30, 2019 23:01
@Lassulus
Copy link
Member

Lassulus commented Apr 30, 2019

@GrahamcOfBorg build ssh-audit

@Lassulus Lassulus merged commit 38b1f61 into NixOS:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lassulus Lassulus Lassulus approved these changes

@aanderse aanderse aanderse requested changes

@tomberek tomberek tomberek approved these changes

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@4z3 @Lassulus @tomberek @aanderse