Skip to content

Prodigal: init at 2.6.3#59834

Merged
marsam merged 1 commit intoNixOS:masterfrom
luispedro:add_prodigal
Apr 19, 2019
Merged

Prodigal: init at 2.6.3#59834
marsam merged 1 commit intoNixOS:masterfrom
luispedro:add_prodigal

Conversation

@luispedro
Copy link
Contributor

@luispedro luispedro commented Apr 18, 2019

Motivation for this change

Prodigal is widely used in bioinformatics.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 18, 2019
marsam
marsam reviewed Apr 19, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a pair of comments, otherwise LGTM

@luispedro
Copy link
Contributor Author

luispedro commented Apr 19, 2019

Thanks! I implemented the comments.

@marsam
Copy link
Contributor

marsam commented Apr 19, 2019

@GrahamcOfBorg build prodigal

@marsam marsam merged commit f84a7b3 into NixOS:master Apr 19, 2019
@marsam
Copy link
Contributor

marsam commented Apr 19, 2019

Thanks!

@luispedro luispedro deleted the add_prodigal branch April 22, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@marsam marsam marsam left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@luispedro @marsam @GrahamcOfBorg