Skip to content

Comments

gnutls: enable latest version on Darwin#58513

Closed
marsam wants to merge 1 commit intoNixOS:masterfrom
marsam:gnutls-darwin
Closed

gnutls: enable latest version on Darwin#58513
marsam wants to merge 1 commit intoNixOS:masterfrom
marsam:gnutls-darwin

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Mar 29, 2019 •
edited
Loading

Motivation for this change

d6454e6 was held back because #24693, which was implemented in #27598 cc: @vcunat

Fixes #58481

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 29, 2019
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 29, 2019
veprbl
veprbl reviewed Mar 31, 2019
View reviewed changes
@vcunat
Copy link
Member

vcunat commented Mar 31, 2019

@GrahamcOfBorg build gnutls

@vcunat vcunat mentioned this pull request Mar 31, 2019
Merged
10 tasks
@vcunat
Copy link
Member

vcunat commented Apr 22, 2019

Superseded by #58611

@vcunat vcunat closed this Apr 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veprbl veprbl veprbl left review comments

@fpletz fpletz fpletz approved these changes

@edolstra edolstra Awaiting requested review from edolstra

+1 more reviewer

@matthewbauer matthewbauer matthewbauer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

insecure GnuTLS on darwin

6 participants

@marsam @vcunat @matthewbauer @fpletz @veprbl @GrahamcOfBorg