Skip to content

rocmPackages: 7.2.3 -> 7.2.4 - #572764

Merged
LunNova merged 6 commits into
NixOS:masterfrom
anund:rocm_7.2.4
Oct 13, 2026
Merged

LunNova merged 6 commits into
NixOS:masterfrom
anund:rocm_7.2.4

Conversation

@anund

@anund anund commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Checking individual commits will help as a large number of version changes are noop's in this update.

Following changes running nix-shell maintainers/scripts/update.nix --argstr team rocm --arg keep-going true --argstr max-workers 4

  • bulk updated most packages as noop changes from retagging upstream
  • rocm-systems change is limited to rcomPackages.clr and rocmPackages.rocprofiler-sdk changes visible here.
  • changes to rocmPacakges.migraphx are cosmetic.
  • rocmPackages.rocmlir includes a single change visible here.
  • found an update for python3Packages.amd-aiter that falls outside the scope of a 7.2.4 update and would require at least one additional dependency to be packaged. It was dropped.
  • found an update for rocmPackages.rocm-docs-core that doesn't fit the 7.2.3 -> 7.2.4 version change so it will be submitted as a separate update
  • manually updated rocmPackages.llvm.llvm as it has no update script
  • reverted update to rocmPackages.rocm-bandwidth-test as it's pinned to 6.3.3 and reported as EOL soon in other PR's.
  • rocmPackages.rocprofiler-sdk was missing the team meta tag and needed to be manually triggered. Many of the previous patches were disturbed but upstream changes to cmake files. Manually reassembling them ended up merging the fmt changes spread across 3 different patch sets.

Release notes: https://rocm.docs.amd.com/en/docs-7.2.4/about/release-notes.html

A step along the way for #563157

Things done

@anund

anund commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review --skip-package-regex python313.*


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • rocmPackages.composable_kernel_base
✅ 82 packages built:
  • adaptivecpp
  • btop-rocm
  • adaptivecppWithCuda
  • adaptivecppWithRocm
  • magma (magma-hip)
  • ollama-rocm
  • llama-cpp-rocm
  • rocmPackages.amdsmi (python314Packages.amdsmi)
  • python314Packages.amd-aiter
  • rocmPackages.aotriton
  • rocmPackages.aqlprofile
  • rocmPackages.ck4inductor
  • rocmPackages.clang (rocmPackages.llvm.clang, rocmPackages.llvm.rocm-toolchain, rocmPackages.rocm-toolchain)
  • rocmPackages.clr
  • rocmPackages.composable_kernel
  • rocmPackages.half
  • rocmPackages.hip-common
  • rocmPackages.hipblas
  • rocmPackages.hipblas-common
  • rocmPackages.hipblaslt
  • rocmPackages.hipcc
  • rocmPackages.hipcub
  • rocmPackages.hipfft
  • rocmPackages.hipfort
  • rocmPackages.hipify
  • rocmPackages.hiprand
  • rocmPackages.hiprt
  • rocmPackages.hipsolver
  • rocmPackages.hipsparse
  • rocmPackages.hipsparselt
  • rocmPackages.hsakmt (rocmPackages.rocm-runtime)
  • rocmPackages.llvm.bintools
  • rocmPackages.llvm.clang-unwrapped
  • rocmPackages.llvm.lld
  • rocmPackages.llvm.llvm
  • rocmPackages.openmp (rocmPackages.llvm.openmp)
  • rocmPackages.stdenv (rocmPackages.rocmClangStdenv)
  • rocmPackages.migraphx
  • rocmPackages.miopen (rocmPackages.miopen-hip)
  • python314Packages.torchWithRocm
  • opensplatWithRocm
  • rocmPackages.mivisionx-cpu
  • rocmPackages.mpi (rocmPackages.openmpi)
  • rocmPackages.mscclpp
  • rocmPackages.rccl
  • rocmPackages.rdc
  • rocmPackages.rocalution
  • rocmPackages.rocblas
  • rocmPackages.rocdbgapi
  • rocmPackages.rocfft
  • rocmPackages.rocgdb
  • rocmPackages.rocm-bandwidth-test
  • rocmPackages.rocm-cmake
  • rocmPackages.rocm-comgr
  • rocmPackages.rocm-core
  • rocmPackages.rocm-device-libs
  • rocmPackages.mivisionx (rocmPackages.mivisionx-hip)
  • rocmPackages.rocm-smi
  • rocmPackages.rocm-tests
  • rocmPackages.rocminfo
  • rocmPackages.rocmlir (rocmPackages.rocmlir-rock)
  • rocmPackages.rocprim
  • rocmPackages.rocprof-compute-viewer
  • rocmPackages.rocprofiler
  • rocmPackages.rocprofiler-register
  • rocmPackages.rocprofiler-sdk
  • rocmPackages.rocr-debug-agent
  • rocmPackages.rocrand
  • rocmPackages.rocshmem
  • rocmPackages.rocsolver
  • rocmPackages.rocsparse
  • rocmPackages.rocthrust
  • rocmPackages.roctracer
  • rocmPackages.rocwmma
  • rocmPackages.rpp (rocmPackages.rpp-hip)
  • rocmPackages.rpp-cpu
  • rocmPackages.rocprof-trace-decoder
  • rocmPackages.tensile
  • stable-diffusion-cpp-rocm
  • rocmPackages.rocm-docs-core
  • zluda
  • voxtype-hip

Note: includes changes to rocm-docs-core that will be submitted as a separate update.

@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. labels Oct 11, 2026
@anund

anund commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Duplicating testing from #506820 using the shell below produces similar results on master vs the update branch for the test program.

{
  pkgs ? import ./nixpkgs { },
  #pkgs ? import <nixpkgs> { },
}:

pkgs.mkShell {
  buildInputs = with pkgs; [
    rocmPackages.llvm.clang
    rocmPackages.rocprofiler-sdk
    rocmPackages.clr
  ];
}

@anund
anund marked this pull request as ready for review October 11, 2026 11:31
@anund

anund commented Oct 11, 2026

Copy link
Copy Markdown
Contributor Author

cc @NixOS/rocm

@nixpkgs-ci
nixpkgs-ci Bot requested review from a team, fangpenlin and lovesegfault October 11, 2026 11:33
@@ -1,42 +0,0 @@
From 2868bcf8a340ecd4c564c1bd3210753fbd6aad8c Mon Sep 17 00:00:00 2001

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed to make patch chain apply.

@@ -1,69 +0,0 @@
From af363337240fb6e4976004900b610317ba459165 Mon Sep 17 00:00:00 2001

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,89 +0,0 @@
From 33058e85d1ee985f9b622bbb2a48199eb55afc20 Mon Sep 17 00:00:00 2001

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed to compile.

@@ -137,54 +116,39 @@ index 46feb0cf51..8a8168186e 100644
+ GTest::gtest
GTest::gtest_main)

rocprofiler_add_unit_test(

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream changes remove some of the patched lines so this was reassembled manually.

@@ -0,0 +1,273 @@
From ecd07af32d8d10bceffc30624b7edbf7f022fe16 Mon Sep 17 00:00:00 2001

@anund anund Oct 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually constructed by working through build errors. Then double checked against previous patches that no longer cleanly apply.

@@ -1,269 +0,0 @@
From ae4cffc06a368893d91be2739bb6482182681efc Mon Sep 17 00:00:00 2001

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer needed to build.

]
++ [
# Can be removed when a release contains the changes found in this pr:
# https://github.com/ROCm/rocm-systems/pull/4721

@anund anund Oct 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Branch merged to develop in late August. No releases contain these changes just yet.

# fmt/core.h to fmt/format.h. backport of the relevant parts of
# https://github.com/ROCm/rocm-systems/commit/e2f588592ecfb0653ed5b3078753186325adf70a
# as upstream has changed significantly since 7.2.3.
./0010-fmt-12.2.0-format.h.patch

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -57,7 +57,7 @@ stdenv.mkDerivation (finalAttrs: {
owner = "ROCm";
repo = "rocm-systems";
tag = "rocm-${finalAttrs.version}";
hash = "sha256-SQjV1FnAgnK1LS5SiApgfvDSjB3AKpucja+PBZSmLvQ=";
hash = "sha256-yI2n1OTym0f3uhuiHDYHs+dr0YGKW/hIlwtkS8ll/R8=";

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting a hash mismatch on this

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦 forgot to invalidate and recalculate the hash after removing some submodule experiments. Changed. New nixpkgs-review spinning.

anund added 5 commits October 12, 2026 16:13
Bulk update of packages retagged upstream from 7.2.4 -> 7.2.4. Source
does not change as a result.
rocm-bandwidth-test is currently pinned to version 6.3.3 and soon EOL
upstream. Remove the updateScript reference to save time reverting
package updates.
@anund

anund commented Oct 12, 2026

Copy link
Copy Markdown
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review --skip-package-regex python313.*
Commit: a1f37187acd9de60cd495a738731dadeefdcec43


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • rocmPackages.composable_kernel_base
✅ 81 packages built:
  • adaptivecppWithRocm
  • adaptivecppWithCuda
  • btop-rocm
  • adaptivecpp
  • magma (magma-hip)
  • ollama-rocm
  • llama-cpp-rocm
  • rocmPackages.amdsmi (python314Packages.amdsmi)
  • python314Packages.amd-aiter
  • rocmPackages.aotriton
  • rocmPackages.aqlprofile
  • rocmPackages.ck4inductor
  • rocmPackages.clang (rocmPackages.llvm.clang, rocmPackages.llvm.rocm-toolchain, rocmPackages.rocm-toolchain)
  • rocmPackages.clr
  • rocmPackages.composable_kernel
  • rocmPackages.half
  • rocmPackages.hip-common
  • rocmPackages.hipblas
  • rocmPackages.hipblas-common
  • rocmPackages.hipblaslt
  • rocmPackages.hipcc
  • rocmPackages.hipcub
  • rocmPackages.hipfft
  • rocmPackages.hipfort
  • rocmPackages.hipify
  • rocmPackages.hiprand
  • rocmPackages.hiprt
  • rocmPackages.hipsolver
  • rocmPackages.hipsparse
  • rocmPackages.hipsparselt
  • rocmPackages.hsakmt (rocmPackages.rocm-runtime)
  • rocmPackages.llvm.bintools
  • rocmPackages.llvm.clang-unwrapped
  • rocmPackages.llvm.lld
  • rocmPackages.llvm.llvm
  • rocmPackages.openmp (rocmPackages.llvm.openmp)
  • rocmPackages.stdenv (rocmPackages.rocmClangStdenv)
  • rocmPackages.migraphx
  • rocmPackages.miopen (rocmPackages.miopen-hip)
  • python314Packages.torchWithRocm
  • opensplatWithRocm
  • rocmPackages.mivisionx (rocmPackages.mivisionx-hip)
  • rocmPackages.mpi (rocmPackages.openmpi)
  • rocmPackages.mscclpp
  • rocmPackages.mivisionx-cpu
  • rocmPackages.rdc
  • rocmPackages.rocalution
  • rocmPackages.rocblas
  • rocmPackages.rocdbgapi
  • rocmPackages.rocfft
  • rocmPackages.rocgdb
  • rocmPackages.rocm-bandwidth-test
  • rocmPackages.rocm-cmake
  • rocmPackages.rocm-comgr
  • rocmPackages.rocm-core
  • rocmPackages.rocm-device-libs
  • rocmPackages.rocm-smi
  • rocmPackages.rocm-tests
  • rocmPackages.rocminfo
  • rocmPackages.rocmlir (rocmPackages.rocmlir-rock)
  • rocmPackages.rocprim
  • rocmPackages.rocprof-compute-viewer
  • rocmPackages.rocprof-trace-decoder
  • rocmPackages.rocprofiler
  • rocmPackages.rocprofiler-register
  • rocmPackages.rocprofiler-sdk
  • rocmPackages.rocr-debug-agent
  • rocmPackages.rocrand
  • rocmPackages.rocshmem
  • rocmPackages.rocsolver
  • rocmPackages.rocsparse
  • rocmPackages.rocthrust
  • rocmPackages.roctracer
  • rocmPackages.rocwmma
  • rocmPackages.rpp (rocmPackages.rpp-hip)
  • rocmPackages.rpp-cpu
  • rocmPackages.tensile
  • stable-diffusion-cpp-rocm
  • voxtype-hip
  • zluda
  • rocmPackages.rccl

@LunNova

LunNova commented Oct 13, 2026

Copy link
Copy Markdown
Member

thanks!

@LunNova
LunNova added this pull request to the merge queue Oct 13, 2026
Merged via the queue into NixOS:master with commit 22a36f3 Oct 13, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rocm ROCm is an Advanced Micro Devices software stack for graphics processing unit programming. 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants