Repository navigation
rocmPackages: 7.2.3 -> 7.2.4 - #572764
rocmPackages: 7.2.3 -> 7.2.4#572764
Conversation
|
|
Duplicating testing from #506820 using the shell below produces similar results on master vs the update branch for the test program. {
pkgs ? import ./nixpkgs { },
#pkgs ? import <nixpkgs> { },
}:
pkgs.mkShell {
buildInputs = with pkgs; [
rocmPackages.llvm.clang
rocmPackages.rocprofiler-sdk
rocmPackages.clr
];
} |
|
cc @NixOS/rocm |
| @@ -1,42 +0,0 @@ | |||
| From 2868bcf8a340ecd4c564c1bd3210753fbd6aad8c Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
No longer needed to make patch chain apply.
| @@ -1,69 +0,0 @@ | |||
| From af363337240fb6e4976004900b610317ba459165 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
| @@ -1,89 +0,0 @@ | |||
| From 33058e85d1ee985f9b622bbb2a48199eb55afc20 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
No longer needed to compile.
| @@ -137,54 +116,39 @@ index 46feb0cf51..8a8168186e 100644 | |||
| + GTest::gtest | |||
| GTest::gtest_main) | |||
|
|
|||
| rocprofiler_add_unit_test( | |||
There was a problem hiding this comment.
Upstream changes remove some of the patched lines so this was reassembled manually.
| @@ -0,0 +1,273 @@ | |||
| From ecd07af32d8d10bceffc30624b7edbf7f022fe16 Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Manually constructed by working through build errors. Then double checked against previous patches that no longer cleanly apply.
| @@ -1,269 +0,0 @@ | |||
| From ae4cffc06a368893d91be2739bb6482182681efc Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
No longer needed to build.
| ] | ||
| ++ [ | ||
| # Can be removed when a release contains the changes found in this pr: | ||
| # https://github.com/ROCm/rocm-systems/pull/4721 |
There was a problem hiding this comment.
🤔 Branch merged to develop in late August. No releases contain these changes just yet.
| # fmt/core.h to fmt/format.h. backport of the relevant parts of | ||
| # https://github.com/ROCm/rocm-systems/commit/e2f588592ecfb0653ed5b3078753186325adf70a | ||
| # as upstream has changed significantly since 7.2.3. | ||
| ./0010-fmt-12.2.0-format.h.patch |
There was a problem hiding this comment.
| @@ -57,7 +57,7 @@ stdenv.mkDerivation (finalAttrs: { | |||
| owner = "ROCm"; | |||
| repo = "rocm-systems"; | |||
| tag = "rocm-${finalAttrs.version}"; | |||
| hash = "sha256-SQjV1FnAgnK1LS5SiApgfvDSjB3AKpucja+PBZSmLvQ="; | |||
| hash = "sha256-yI2n1OTym0f3uhuiHDYHs+dr0YGKW/hIlwtkS8ll/R8="; | |||
There was a problem hiding this comment.
getting a hash mismatch on this
There was a problem hiding this comment.
🤦 forgot to invalidate and recalculate the hash after removing some submodule experiments. Changed. New nixpkgs-review spinning.
Bulk update of packages retagged upstream from 7.2.4 -> 7.2.4. Source does not change as a result.
rocm-bandwidth-test is currently pinned to version 6.3.3 and soon EOL upstream. Remove the updateScript reference to save time reverting package updates.
|
|
thanks! |
Checking individual commits will help as a large number of version changes are noop's in this update.
Following changes running
nix-shell maintainers/scripts/update.nix --argstr team rocm --arg keep-going true --argstr max-workers 4rcomPackages.clrandrocmPackages.rocprofiler-sdkchanges visible here.rocmPacakges.migraphxare cosmetic.rocmPackages.rocmlirincludes a single change visible here.python3Packages.amd-aiterthat falls outside the scope of a 7.2.4 update and would require at least one additional dependency to be packaged. It was dropped.rocmPackages.rocm-docs-corethat doesn't fit the 7.2.3 -> 7.2.4 version change so it will be submitted as a separate updaterocmPackages.llvm.llvmas it has no update scriptrocmPackages.rocm-bandwidth-testas it's pinned to 6.3.3 and reported as EOL soon in other PR's.rocmPackages.rocprofiler-sdkwas missing the teammetatag and needed to be manually triggered. Many of the previous patches were disturbed but upstream changes tocmakefiles. Manually reassembling them ended up merging thefmtchanges spread across 3 different patch sets.Release notes: https://rocm.docs.amd.com/en/docs-7.2.4/about/release-notes.html
A step along the way for #563157
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.