buildRustPackage: Allow pname attribute#56634
Merged
Mic92 merged 1 commit intoNixOS:masterfrom Mar 11, 2019
marsam:buildrustcreate-pname-attribute
Merged
buildRustPackage: Allow pname attribute#56634Mic92 merged 1 commit intoNixOS:masterfrom marsam:buildrustcreate-pname-attribute
Mic92 merged 1 commit intoNixOS:masterfrom
marsam:buildrustcreate-pname-attribute
Conversation
worldofpeace
approved these changes
Mar 9, 2019
dtzWill
approved these changes
Mar 11, 2019
Member
|
backport: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since #49398 most of the package build helpers accept
pname, butbuildRustPackagewas missing this featureThings done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)