Skip to content

buildRustPackage: Allow pname attribute#56634

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
marsam:buildrustcreate-pname-attribute
Mar 11, 2019
Merged

buildRustPackage: Allow pname attribute#56634
Mic92 merged 1 commit intoNixOS:masterfrom
marsam:buildrustcreate-pname-attribute

Conversation

@marsam
Copy link
Contributor

@marsam marsam commented Mar 2, 2019

Motivation for this change

Since #49398 most of the package build helpers accept pname, but buildRustPackage was missing this feature

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 2, 2019
@worldofpeace worldofpeace requested a review from Mic92 March 9, 2019 18:15
@Mic92 Mic92 merged commit cd498f7 into NixOS:master Mar 11, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 11, 2019

backport:
[detached HEAD 5f3be9b] buildRustPackage: Allow pname attribute
Author: Mario Rodas marsam@users.noreply.github.com
Date: Fri Mar 1 21:45:12 2019 -0500
1 file changed, 2 insertions(+), 1 deletion(-)

@marsam marsam deleted the buildrustcreate-pname-attribute branch March 11, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants