all-packages.nix: move defaults to package files continues

[oxij]

What? Why?

A continuation of #55129. This one also integrates a bit of #35374.

git log

• *: move defaults to package file

A bunch of these.

nix-instantiate environment

• Host OS: Linux 4.9, SLNOS 19.03
• Nix: nix-env (Nix) 2.1.3
• Multi-user: yes
• Sandbox: yes
• NIXPKGS_CONFIG:

{
  checkMeta = true;
  doCheckByDefault = true;
}

nix-env -qaP diffs

• On x86_64-linux: noop
• On aarch64-linux: noop
• On x86_64-darwin: noop

/cc @Mic92 @ryantm @Ericson2314 @infinisil @bendlas @jtojnar @pbogdan @abbradar from git-blame and @7c6f434c from #55129

[7c6f434c]

I want to wait for objections, not just for ofborg, but I do like this

[bendlas]

I tend towards liking it as well, but don't have any thought out rationale.

cc @volth objected to doing something like this for chromium, IIRC

[oxij]

Well, ofborg, I guess I can just make this a noop.

[oxij]

I wonder, what ofborg thinks is a rebuild on darwin? nix-env diff between master and a merge of this and master is empty on my machine.

Anyway, can we merge yet?

[samueldr]

ofborg seems to think direwolf has changed for darwin. Though it's something that fails to instantiate here, and looked unrelated?

---

In the GitHub interface, in the list of checks from ofborg, the Details link on the grahamcofborg-eval line will point to a gist with the list of changed attributes.

• https://gist.github.com/GrahamcOfBorg/1b330209e4adba893480a7741b19b23e

(There is an annoying bug in GitHub where a merged PR will add a bogus Details link to all lines, even those without a Details page to link to.)

In case you're ever curious what ofborg saw. This might be a good place to start checking how it sniffs changes. (Most of the implementation is in outpathdiff.rs.)

[oxij]

I see. Thanks! and for pointers.