Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
1ad836b
dwm: cleanup whitespace
oxij Feb 3, 2019
d35c199
dysnomia: cleanup whitespace
oxij Feb 3, 2019
735d287
pulseaudioFull, libpulseaudio-vanilla: cleanup
oxij Feb 3, 2019
849b10a
top-level: fix a typo
oxij Feb 3, 2019
107f0fc
top-level: cleanup whitespace
oxij Feb 3, 2019
51687d9
lib: tiny cleanup
oxij Feb 3, 2019
6832a42
avahi: move defaults to the package file
oxij Feb 3, 2019
6cb5666
profanity: move defaults to package file
oxij Feb 3, 2019
5da88a1
rsync: move defaults to package file
oxij Feb 3, 2019
d064592
ghostscript: move defaults to package file
oxij Feb 3, 2019
35a09f9
evilvte: move defaults to package file
oxij Feb 3, 2019
7706253
libspotify: move defaults to package file
oxij Feb 3, 2019
679bf2a
flashplayer: move defaults to package file
oxij Feb 3, 2019
25709df
tomahawk: move defaults to package file
oxij Feb 3, 2019
8cbe72a
w3m: move defaults to package file
oxij Feb 3, 2019
ec122cc
dysnomia: move defaults to package file
oxij Feb 3, 2019
bdd69a9
sane-backends, sane-backends-git: move defaults to package file
oxij Feb 3, 2019
a4f2097
fetchsvnssh: move defaults to package file
oxij Feb 3, 2019
4bc9404
grub: move defaults to package file
oxij Feb 3, 2019
546c8ff
ssmtp: move defaults to package file
oxij Feb 3, 2019
6e1e0bb
urjtag: move defaults to package file
oxij Feb 3, 2019
c1ee0a4
aprutil: move defaults to package file
oxij Feb 3, 2019
4ec5cbc
libgpod: move defaults to package file
oxij Feb 3, 2019
866944f
mpd: move defaults to package file
oxij Feb 3, 2019
a4cebde
mercurial: move defaults to package file
oxij Feb 3, 2019
b5e511d
rxvt_unicode: move defaults to package file
oxij Feb 3, 2019
1b784e5
subversion: move defaults to package file
oxij Feb 3, 2019
2cf1407
residualvm: move defaults to package file
oxij Feb 3, 2019
50153af
arduino-core: move defaults to package file
oxij Feb 3, 2019
58a2757
ibus-with-plugins: move defaults to package file
oxij Feb 3, 2019
caff8b7
mjpegtools: move defaults to package file
oxij Feb 3, 2019
ce75344
stoken: move defaults to package file
oxij Feb 3, 2019
f56be70
uwsgi: move defaults to package file
oxij Feb 3, 2019
56ee5bc
wireshark: move defaults to package file
oxij Feb 3, 2019
4f066da
quassel: move defaults to package file
oxij Feb 3, 2019
ec2452d
scilab: move defaults to package file
oxij Feb 3, 2019
f37effb
gams: move defaults to package file
oxij Feb 3, 2019
88ca6dd
cplex: move defaults to package file
oxij Feb 3, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/customisation.nix
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ rec {
auto = builtins.intersectAttrs (lib.functionArgs f) autoArgs;
origArgs = auto // args;
pkgs = f origArgs;
mkAttrOverridable = name: pkg: makeOverridable (newArgs: (f newArgs).${name}) origArgs;
mkAttrOverridable = name: _: makeOverridable (newArgs: (f newArgs).${name}) origArgs;
in lib.mapAttrs mkAttrOverridable pkgs;


Expand Down
2 changes: 1 addition & 1 deletion pkgs/applications/misc/evilvte/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ stdenv, fetchgit, makeWrapper, pkgconfig,
gnome2, glib, pango, cairo, gdk_pixbuf, atk, freetype, xorg,
configH
configH ? ""
}:

stdenv.mkDerivation rec {
Expand Down
4 changes: 2 additions & 2 deletions pkgs/applications/misc/rxvt_unicode/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ stdenv, fetchurl, makeDesktopItem, perlSupport, libX11, libXt, libXft,
{ stdenv, fetchurl, makeDesktopItem, perlSupport ? true, libX11, libXt, libXft,
ncurses, perl, fontconfig, freetype, pkgconfig, libXrender,
gdkPixbufSupport, gdk_pixbuf, unicode3Support }:
gdkPixbufSupport ? true, gdk_pixbuf, unicode3Support ? true }:

let
pname = "rxvt-unicode";
Expand Down
2 changes: 1 addition & 1 deletion pkgs/applications/networking/browsers/w3m/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{ stdenv, fetchFromGitHub, fetchpatch
, ncurses, boehmgc, gettext, zlib
, sslSupport ? true, openssl ? null
, graphicsSupport ? true, imlib2 ? null
, graphicsSupport ? !stdenv.isDarwin, imlib2 ? null
, x11Support ? graphicsSupport, libX11 ? null
, mouseSupport ? !stdenv.isDarwin, gpm-ncurses ? null
, perl, man, pkgconfig, buildPackages, w3m
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
, glibcLocales, expect, ncurses, libotr, curl, readline, libuuid
, cmocka, libmicrohttpd, stabber, expat, libmesode

, autoAwaySupport ? false, libXScrnSaver ? null, libX11 ? null
, notifySupport ? false, libnotify ? null, gdk_pixbuf ? null
, traySupport ? false, gnome2 ? null
, autoAwaySupport ? true, libXScrnSaver ? null, libX11 ? null
, notifySupport ? true, libnotify ? null, gdk_pixbuf ? null
, traySupport ? true, gnome2 ? null
, pgpSupport ? true, gpgme ? null
, pythonPluginSupport ? true, python ? null
}:
Expand Down
4 changes: 2 additions & 2 deletions pkgs/applications/networking/irc/quassel/default.nix
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{ monolithic ? true # build monolithic Quassel
, daemon ? false # build Quassel daemon
, client ? false # build Quassel client
, tag ? "" # tag added to the package name
, tag ? "-kf5" # tag added to the package name
, static ? false # link statically

, stdenv, fetchFromGitHub, cmake, makeWrapper, dconf
, qtbase, qtscript
, phonon, libdbusmenu, qca-qt5

, withKDE ? stdenv.isLinux # enable KDE integration
, withKDE ? true # enable KDE integration
, extra-cmake-modules
, kconfigwidgets
, kcoreaddons
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
, gnutls, libgcrypt, libgpgerror, geoip, openssl, lua5, python, libcap, glib
, libssh, zlib, cmake, extra-cmake-modules, fetchpatch, makeWrapper
, withGtk ? false, gtk3 ? null, librsvg ? null, gsettings-desktop-schemas ? null, wrapGAppsHook ? null
, withQt ? false, qt5 ? null
, withQt ? true, qt5 ? null
, ApplicationServices, SystemConfiguration, gmp
}:

Expand Down
2 changes: 1 addition & 1 deletion pkgs/applications/networking/sync/rsync/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{ stdenv, fetchurl, perl, libiconv, zlib, popt
, enableACLs ? true, acl ? null
, enableACLs ? !(stdenv.isDarwin || stdenv.isSunOS || stdenv.isFreeBSD), acl ? null
, enableCopyDevicesPatch ? false
}:

Expand Down
2 changes: 1 addition & 1 deletion pkgs/applications/science/math/cplex/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, makeWrapper, openjdk, gtk2, xorg, glibcLocales, releasePath }:
{ stdenv, makeWrapper, openjdk, gtk2, xorg, glibcLocales, releasePath ? null }:

# To use this package, you need to download your own cplex installer from IBM
# and override the releasePath attribute to point to the location of the file.
Expand Down
6 changes: 3 additions & 3 deletions pkgs/applications/science/math/scilab/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@
, ncurses
, withXaw3d ? false
#, withPVMlib ? false
, tcl, tk, withTk ? false
, tcl, tk, withTk ? true
, gtk2, withGtk ? false # working ?
#, withF2c ? false
, ocaml, withOCaml ? false
, ocaml, withOCaml ? true
#, withJava ? false
#, atlasMath, withAtlas ? false
, xlibsWrapper, withX ? false
, xlibsWrapper, withX ? true
}:

stdenv.mkDerivation rec {
Expand Down
4 changes: 2 additions & 2 deletions pkgs/applications/version-management/subversion/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ bdbSupport ? false # build support for Berkeley DB repositories
{ bdbSupport ? true # build support for Berkeley DB repositories
, httpServer ? false # build Apache DAV module
, httpSupport ? false # client must support http
, httpSupport ? true # client must support http
, pythonBindings ? false
, perlBindings ? false
, javahlBindings ? false
Expand Down
8 changes: 4 additions & 4 deletions pkgs/applications/window-managers/dwm/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -5,21 +5,21 @@ let
in
stdenv.mkDerivation {
inherit name;

src = fetchurl {
url = "https://dl.suckless.org/dwm/${name}.tar.gz";
sha256 = "1zkmwb6df6m254shx06ly90c0q4jl70skk1pvkixpb7hcxhwbxn2";
};

buildInputs = [ libX11 libXinerama libXft ];

prePatch = ''sed -i "s@/usr/local@$out@" config.mk'';

# Allow users set their own list of patches
inherit patches;

buildPhase = " make ";

meta = {
homepage = https://suckless.org/;
description = "Dynamic window manager for X";
Expand Down
2 changes: 1 addition & 1 deletion pkgs/build-support/fetchsvnssh/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{stdenvNoCC, subversion, sshSupport ? false, openssh ? null, expect}:
{stdenvNoCC, subversion, sshSupport ? true, openssh ? null, expect}:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoud this openssh ? null become just openssh if the local default for ssh support is true?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory: no preference, in practice: it usually it is not in most other expressions.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default will have the openssh argument, so getting null already needs an explicit override, no?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking, the default it will get depends on callPackage implementation used, so the above should be okay, normally. In this instance, however, the output will depend on openssh anyway because the path gets burned into derivation irrespective of sshSupport. I'm not sure if fixing this should be in scope of this PR, though.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was only asking about default argument values, I agree with both your implied claims (ignoring the argument if the support if off is good, but fixing this is out of scope).

I think if it is called in Nixpkgs exactly once, it is acceptable to assume this is the only type of callPackage that will be applied.

{username, password, url, rev ? "HEAD", md5 ? "", sha256 ? ""}:


Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/libraries/apr-util/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{ stdenv, fetchurl, makeWrapper, apr, expat, gnused
, sslSupport ? true, openssl
, bdbSupport ? false, db
, bdbSupport ? true, db
, ldapSupport ? !stdenv.isCygwin, openldap
, libiconv
, cyrus_sasl, autoreconfHook
Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/libraries/libgpod/default.nix
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{stdenv, lib, fetchurl, gettext, perlPackages, intltool, pkgconfig, glib,
libxml2, sqlite, zlib, sg3_utils, gdk_pixbuf, taglib,
libimobiledevice, pythonPackages, mutagen,
monoSupport ? true, mono, gtk-sharp-2_0
monoSupport ? false, mono, gtk-sharp-2_0
}:

let
Expand Down
2 changes: 1 addition & 1 deletion pkgs/development/libraries/libspotify/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchurl, libspotify, alsaLib, readline, pkgconfig, apiKey, unzip, gnused }:
{ stdenv, fetchurl, libspotify, alsaLib, readline, pkgconfig, apiKey ? null, unzip, gnused }:

let
version = "12.1.51";
Expand Down
3 changes: 2 additions & 1 deletion pkgs/games/residualvm/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ stdenv, fetchurl, SDL, zlib, libmpeg2, libmad, libogg, libvorbis, flac, alsaLib
, openglSupport ? false, libGLU_combined ? null
, libGLSupported
, openglSupport ? libGLSupported, libGLU_combined ? null
}:

assert openglSupport -> libGLU_combined != null;
Expand Down
7 changes: 4 additions & 3 deletions pkgs/misc/ghostscript/default.nix
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
{ stdenv, lib, fetchurl, pkgconfig, zlib, expat, openssl, autoconf
{ config, stdenv, lib, fetchurl, pkgconfig, zlib, expat, openssl, autoconf
, libjpeg, libpng, libtiff, freetype, fontconfig, libpaper, jbig2dec
, libiconv, ijs
, x11Support ? false, xlibsWrapper ? null
, cupsSupport ? false, cups ? null
, cupsSupport ? config.ghostscript.cups or (!stdenv.isDarwin), cups ? null
, x11Support ? cupsSupport, xlibsWrapper ? null # with CUPS, X11 only adds very little

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat borderline on that… (I do not oppose that, but do not actively suport and will wait longer for objections to this change before merging)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that is exactly what was written in all-packages.nix before this change.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the logic, I am just not sure if this type of extracting defaults from contents of other arguments is something everyone has made peace with.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I felt this was a common thing to do, grep -rE '.*Support \? .*Support' gives a lot of results.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to comment on the entire two-line combo — …Support ? …Support but together with …Support ? config.…

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Well, a) it is just another variable binding, so not that much of a difference, IMHO b) I don't see any other options in this case as applying config.ghostscript or {} in all-packages.nix will do the wrong thing.

}:

assert x11Support -> xlibsWrapper != null;
assert cupsSupport -> cups != null;

let
version = "9.${ver_min}";
ver_min = "26";
Expand Down
6 changes: 3 additions & 3 deletions pkgs/servers/uwsgi/default.nix
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{ stdenv, lib, fetchurl, pkgconfig, jansson, pcre
# plugins: list of strings, eg. [ "python2" "python3" ]
, plugins
, pam, withPAM ? false
, systemd, withSystemd ? false
, plugins ? []
, pam, withPAM ? stdenv.isLinux
, systemd, withSystemd ? stdenv.isLinux
, python2, python3, ncurses
, ruby, php-embed, mysql
}:
Expand Down
2 changes: 1 addition & 1 deletion pkgs/tools/inputmethods/ibus/wrapper.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{ stdenv, runCommand, makeWrapper, lndir
, dconf, hicolor-icon-theme, ibus, librsvg, plugins
, dconf, hicolor-icon-theme, ibus, librsvg, plugins ? []
}:

let
Expand Down
2 changes: 1 addition & 1 deletion pkgs/tools/misc/gams/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ stdenv, fetchurl, unzip, file, licenseFile, optgamsFile}:
{ stdenv, fetchurl, unzip, file, licenseFile ? null, optgamsFile ? null}:

assert licenseFile != null;

Expand Down
8 changes: 4 additions & 4 deletions pkgs/tools/misc/urjtag/default.nix
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{ stdenv, autoconf, automake, pkgconfig, gettext, libtool, bison
, flex, which, subversion, fetchsvn, makeWrapper, libftdi, libusb, readline
, python3
, svfSupport ? false
, bsdlSupport ? false
, staplSupport ? false
, jedecSupport ? false
, svfSupport ? true
, bsdlSupport ? true
, staplSupport ? true
, jedecSupport ? true
}:

stdenv.mkDerivation rec {
Expand Down
2 changes: 1 addition & 1 deletion pkgs/tools/networking/ssmtp/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{stdenv, fetchurl, tlsSupport ? false, openssl ? null}:
{stdenv, fetchurl, tlsSupport ? true, openssl ? null}:

assert tlsSupport -> openssl != null;

Expand Down
4 changes: 2 additions & 2 deletions pkgs/tools/package-management/disnix/dysnomia/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ stdenv.mkDerivation {
};

preConfigure = if enableEjabberdDump then "export PATH=$PATH:${ejabberd}/sbin" else "";

configureFlags = [
(if enableApacheWebApplication then "--with-apache" else "--without-apache")
(if enableAxis2WebService then "--with-axis2" else "--without-axis2")
Expand All @@ -39,7 +39,7 @@ stdenv.mkDerivation {
(if enableMongoDatabase then "--with-mongodb" else "--without-mongodb")
"--with-job-template=${jobTemplate}"
];

buildInputs = [ getopt ]
++ stdenv.lib.optional enableEjabberdDump ejabberd
++ stdenv.lib.optional enableMySQLDatabase mysql.out
Expand Down
2 changes: 1 addition & 1 deletion pkgs/tools/video/mjpegtools/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{ stdenv, lib, fetchurl, gtk2, libdv, libjpeg, libpng, libX11, pkgconfig, SDL, SDL_gfx
, withMinimal ? false
, withMinimal ? true
}:

# TODO:
Expand Down
Loading