Skip to content

Comments

ocamlPackages.lablgtk: make glade support optional#54321

Closed
vbgl wants to merge 1 commit intoNixOS:masterfrom
vbgl:ocaml-lablgtk-noglade
Closed

ocamlPackages.lablgtk: make glade support optional#54321
vbgl wants to merge 1 commit intoNixOS:masterfrom
vbgl:ocaml-lablgtk-noglade

Conversation

@vbgl
Copy link
Contributor

@vbgl vbgl commented Jan 19, 2019 •
edited
Loading

Motivation for this change

gnome2.libglade has been broken on darwin for a while (e.g., https://hydra.nixos.org/build/85407675).

Disabling Glade and GnomeCanvas (which also depends on libglade) support breaks monotoneViz, and the GUI of frama-c.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl vbgl added the 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. label Jan 19, 2019
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 19, 2019
@vbgl
Copy link
Contributor Author

vbgl commented Jan 19, 2019

@GrahamcOfBorg build coq

@vbgl vbgl force-pushed the ocaml-lablgtk-noglade branch from 2203866 to 6473000 Compare January 19, 2019 16:37
@vbgl
Copy link
Contributor Author

vbgl commented Jan 20, 2019

@GrahamcOfBorg build coq

@vbgl
Copy link
Contributor Author

vbgl commented Jan 22, 2019

@GrahamcOfBorg build unison

@vbgl vbgl mentioned this pull request Jan 22, 2019
Closed
10 tasks
@Mic92
Copy link
Member

Mic92 commented Jan 22, 2019

Sounds good to me.

@vbgl vbgl deleted the ocaml-lablgtk-noglade branch September 13, 2022 07:28
@emilazy emilazy mentioned this pull request Apr 26, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees

No one assigned

Labels

6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vbgl @Mic92 @GrahamcOfBorg