Skip to content

sip: modify module name only for use with PyQt5#52946

Closed
veprbl wants to merge 1 commit intoNixOS:masterfrom
veprbl:pr/pyqt5_sip
Closed

sip: modify module name only for use with PyQt5#52946
veprbl wants to merge 1 commit intoNixOS:masterfrom
veprbl:pr/pyqt5_sip

Conversation

@veprbl
Copy link
Member

@veprbl veprbl commented Dec 27, 2018

Motivation for this change

Fixes: #52613
Closes: #52897

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl requested a review from FRidh as a code owner December 27, 2018 00:06
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 27, 2018
@orivej
Copy link
Contributor

orivej commented Dec 27, 2018

I consider #52897 a better approach for the reasons stated there, but I have tested this one too with tortoisehg and cura, and it works. I have made a cleaner PR based on my earlier attempt at #52956.

@veprbl
Copy link
Member Author

veprbl commented Dec 27, 2018

Oh great! You even removed sip from propagatedBuildInputs. This is definitely an improvement.

@veprbl veprbl closed this Dec 27, 2018
@veprbl veprbl deleted the pr/pyqt5_sip branch December 1, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@veprbl @orivej @GrahamcOfBorg