Skip to content

ola: use python36#52097

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:ola-python36
Dec 15, 2018
Merged

ola: use python36#52097
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:ola-python36

Conversation

@dotlambda
Copy link
Member

Motivation for this change

python37.pkgs.protobuf does not build with protobuf3_1
Fixes #52090.
A similar thing has been done in #51809.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

python37.pkgs.protobuf does not build with protobuf3_1
@dotlambda dotlambda requested a review from globin December 14, 2018 18:57
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 14, 2018
@dotlambda dotlambda merged commit d425500 into NixOS:master Dec 15, 2018
@peternewman
Copy link

Just FYI, OLA doesn't currently work with Python 3. We're working on it, and it's got a lot better, but it's not all there yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed build python3.7-protobuf

3 participants