Skip to content

Submit/gtk and more#517

Closed
MarcWeber wants to merge 4 commits intoNixOS:masterfrom
MarcWeber:submit/gtk-and-more
Closed

Submit/gtk and more#517
MarcWeber wants to merge 4 commits intoNixOS:masterfrom
MarcWeber:submit/gtk-and-more

Conversation

@MarcWeber
Copy link
Contributor

patch against x-updates branch

  • improve gtk3 and gobjectIntrospection support
  • adding colord, mypaint (git), dispcalgui

The patch experimental/multiple-versions-in-one-file is also in trunk but has not been merged into x-updates yet

MarcWeber added 4 commits May 10, 2013 19:18
gtk3 related updates:
pygtk is now contained in pygobject
gobjectIntrospection now creates interface files:
- typelib files
- gir files
typelib files are compressed gir files
Eventually multiple derivation outputs should be used, because uncompressed gir
xml files are huge (30% of the final gobject gtk derivation for instance)

this makes it possible to compile:
- gnome color manager (colord)
- dispcalgui
- mypaint (git version)
This patch introduces mergeAttrsByVersion to lib.

In some cases it does make sense to keep "experimental" and "older" versions of
the same package in one file because it follows the "do it once only" principle.
Very often many versions share their build instructions - so even though I
understand Eelcos opinion that different versions should be put into their own
.nix files - its my feeling telling me that this is fastest for most cases.

I agree with Eelco that if tweaks for individual versions become too much they
should be split into individual files.

See comments above mergeAttrsByVersion learn about its usage.

Signed-off-by: Marc Weber <marco-oweber@gmx.de>

Conflicts:
	pkgs/lib/misc.nix
adding colord
@vcunat
Copy link
Member

vcunat commented Jul 29, 2013

I looked at this more thoroughly, and it seems to me that the introspection data isn't really a big part, locale is usually much larger (and mostly unused as well). Thus, I would keep it as it is now.

I solved conflicts against x-updates here https://github.com/vcunat/nixpkgs/commits/vlada/introspection (simple). I would merge it, only colord seems outdated (maybe others as well, I haven't tried to build all yet). Do you have some updates for this in your repos?

@MarcWeber
Copy link
Contributor Author

I added it to my todo list, may take a week this time.

@vcunat
Copy link
Member

vcunat commented Jul 29, 2013

No need to hurry, I know about no plans to merge x-updates soon anyway.

vcunat added a commit that referenced this pull request Aug 4, 2013
This is all work of Marc Weber <marco-oweber@gmx.de>, except for a few nitpicks.

Tested space blowup: IMHO negligible to headers and similar stuff,
e.g. the firefox closure (reported by du) grows from 560 to 579 MB.
Saving space should be handled separately,
e.g. we have the multiple-outputs branch.
@vcunat
Copy link
Member

vcunat commented Aug 4, 2013

Hmm, x-updates is likely to merge soon, after all (with minor safe stuff mostly). Therefore, I picked the lib updates from this which seemed without any problem (I did just some nitpicks). The rest can be easily pushed directly to master afterwards, as it only affects few packages.

MarcWeber added a commit to MarcWeber/nixpkgs that referenced this pull request Aug 8, 2013
…fixes

* commit 'refs/top-bases/tmp/x-updates-fixes': (809 commits)
  introspection disabling -- clutter-gtk, NM-applet, gnome_panel
  disable auto-detected introspection for libwnck and clutter
  add introspection into GTK libs (part of NixOS#517)
  xorg: bugfix updates of some libs
  poppler: bugfix update, waiting with major bump
  clean some include flags that weren't really needed
  GTK-related minor updates
  automake113x: minor update to .4
  mesa: bugfix update 9.1.4 -> 9.1.6
  idris: upgrade to 0.9.9
  add haskell-llvm-general
  blivet: Update sha256, as it changed upstream.
  nixpart: Update to bugfix version 0.4.1.
  Adding CL-Launch. CL-Launch is a wrapper for unified launching of various Lisp implementations
  Add simple hsetroot package.
  git-subtree: Remove
  git: Install git-subtree
  git: Update to 1.8.3.4
  VM builds: Reduce kernel verbosity
  VM builds: Use the default kernel
  ...

Conflicts:
	pkgs/development/libraries/glib/default.nix
MarcWeber added a commit to MarcWeber/nixpkgs that referenced this pull request Aug 8, 2013
* tmp/x-updates-fixes: (809 commits)
  introspection disabling -- clutter-gtk, NM-applet, gnome_panel
  disable auto-detected introspection for libwnck and clutter
  add introspection into GTK libs (part of NixOS#517)
  xorg: bugfix updates of some libs
  poppler: bugfix update, waiting with major bump
  clean some include flags that weren't really needed
  GTK-related minor updates
  automake113x: minor update to .4
  mesa: bugfix update 9.1.4 -> 9.1.6
  idris: upgrade to 0.9.9
  add haskell-llvm-general
  blivet: Update sha256, as it changed upstream.
  nixpart: Update to bugfix version 0.4.1.
  Adding CL-Launch. CL-Launch is a wrapper for unified launching of various Lisp implementations
  Add simple hsetroot package.
  git-subtree: Remove
  git: Install git-subtree
  git: Update to 1.8.3.4
  VM builds: Reduce kernel verbosity
  VM builds: Use the default kernel
  ...
MarcWeber added a commit to MarcWeber/nixpkgs that referenced this pull request Aug 8, 2013
* commit '0825416': (1767 commits)
  introspection disabling -- clutter-gtk, NM-applet, gnome_panel
  disable auto-detected introspection for libwnck and clutter
  add introspection into GTK libs (part of NixOS#517)
  xorg: bugfix updates of some libs
  poppler: bugfix update, waiting with major bump
  clean some include flags that weren't really needed
  GTK-related minor updates
  automake113x: minor update to .4
  mesa: bugfix update 9.1.4 -> 9.1.6
  idris: upgrade to 0.9.9
  add haskell-llvm-general
  blivet: Update sha256, as it changed upstream.
  nixpart: Update to bugfix version 0.4.1.
  Adding CL-Launch. CL-Launch is a wrapper for unified launching of various Lisp implementations
  Add simple hsetroot package.
  git-subtree: Remove
  git: Install git-subtree
  git: Update to 1.8.3.4
  VM builds: Reduce kernel verbosity
  VM builds: Use the default kernel
  ...

Conflicts:
	pkgs/development/libraries/atk/default.nix
MarcWeber added a commit to MarcWeber/nixpkgs that referenced this pull request Aug 8, 2013
* tmp/gtk3: (1767 commits)
  introspection disabling -- clutter-gtk, NM-applet, gnome_panel
  disable auto-detected introspection for libwnck and clutter
  add introspection into GTK libs (part of NixOS#517)
  xorg: bugfix updates of some libs
  poppler: bugfix update, waiting with major bump
  clean some include flags that weren't really needed
  GTK-related minor updates
  automake113x: minor update to .4
  mesa: bugfix update 9.1.4 -> 9.1.6
  idris: upgrade to 0.9.9
  add haskell-llvm-general
  blivet: Update sha256, as it changed upstream.
  nixpart: Update to bugfix version 0.4.1.
  Adding CL-Launch. CL-Launch is a wrapper for unified launching of various Lisp implementations
  Add simple hsetroot package.
  git-subtree: Remove
  git: Install git-subtree
  git: Update to 1.8.3.4
  VM builds: Reduce kernel verbosity
  VM builds: Use the default kernel
  ...

Conflicts:
	pkgs/lib/misc.nix
Phreedom pushed a commit that referenced this pull request Sep 15, 2013
@vcunat
Copy link
Member

vcunat commented Sep 18, 2013

Much of this has been already merged somehow. Is there something left? Rebase?

@MarcWeber
Copy link
Contributor Author

Eventually some packages. But you're right that should retest it and send an update. Please give me a couple of days to do so.

@MarcWeber
Copy link
Contributor Author

dispcalgui might still be missing. I'll create a new pull request for that, soon.

@MarcWeber MarcWeber closed this Sep 19, 2013
@MarcWeber MarcWeber mentioned this pull request Sep 20, 2013
notklea pushed a commit to notklea/nixpkgs that referenced this pull request Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants