Skip to content

rustc: 1.30.1 -> 1.31.0#51632

Closed
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92:rustc
Closed

rustc: 1.30.1 -> 1.31.0#51632
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92:rustc

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 6, 2018

Motivation for this change
  • aarch64-linux
  • x86_64-linux
  • x86_64-darwin
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from LnL7 as a code owner December 6, 2018 18:57
@GrahamcOfBorg GrahamcOfBorg added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Dec 6, 2018
@Mic92
Copy link
Member Author

Mic92 commented Dec 6, 2018

I am looking for someone who wants to volunteer for macOS.
For testing I would recommend to build a rust package such as fd and test it.

@grahamc
Copy link
Member

grahamc commented Dec 6, 2018

on darwin: rustc 1.31 built fine, and I built the rust / cargo package fd and that worked fine, too :)

@Mic92
Copy link
Member Author

Mic92 commented Dec 6, 2018

pushed to staging: 3a5b4a6

@Mic92 Mic92 closed this Dec 6, 2018
@Mic92 Mic92 deleted the rustc branch December 6, 2018 22:22
@djahandarie
Copy link
Contributor

@Mic92 Thanks for this! Is there someone that should be cc'd to make the staging->master merge happen, or is that process fairly automated/alive on its own at this point?

@Mic92
Copy link
Member Author

Mic92 commented Dec 12, 2018

It is a manual task. Currently staging-next is under stabilization: #51444
This pull request is not included there, so it will be in the next round.
If you want to use rustc right now, you can use either the mozilla-overlay,
rustup or override rustc.src in your packageOverrides/overlay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants