fetchPnpmDeps: deprecate fetcherVersion = 1, schedule removal for 26.11#513215
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 1-10
qweered
force-pushed
the
remove-fetcherVersion-1
branch
from
fe4a0e4 to
4fa048a
Compare
Contributor
Author
|
We still have 2 days untill no breaking changes. Can be backported to 26.05 later cause its just a warn |
nixpkgs-ci
Bot
added
8.has: changelog
15 tasks
Scrumplex
reviewed
Apr 25, 2026
Scrumplex
left a comment
Scrumplex
left a comment
Member
There was a problem hiding this comment.
I don't think this has to be gated by the oldest supported release at all. We can start warning immediately once this is merged, as 26.05 will not include any packages with fetcherVersion = 1; at this rate.
Scrumplex
force-pushed
the
remove-fetcherVersion-1
branch
2 times, most recently
from
a77f3f1 to
1d4d2c2
Compare
Contributor
Author
|
Thank you for force push, I was quiet busy yesterday. LGTM, lets merge #513204 and its ready to go |
qweered
force-pushed
the
remove-fetcherVersion-1
branch
from
1d4d2c2 to
e22cd00
Compare
10 tasks
Member
|
@qweered Do you mind rebasing this to fix the CI? |
fetcherVersion = 1 was kept around for backwards compatibility while callers migrated to 2/3. Emit a `lib.warnIf` warning pointing at the affected pname whenever v1 is used. After 26.11 ships, a follow-up PR should drop 1 from `supportedFetcherVersions` and clean up the dead v1 code paths in default.nix, pnpm-config-hook.sh and serve.nix. Also rewrite the manual section to recommend fetcherVersion = 3 for new packages and mark v1 as deprecated/scheduled-for-removal in the version history. Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
qweered
force-pushed
the
remove-fetcherVersion-1
branch
from
e22cd00 to
6b6d15b
Compare
Scrumplex
approved these changes
Apr 26, 2026
nixpkgs-ci
Bot
added
the
12.approvals: 1
Member
|
Thank you! |
13 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/breaking-changes-announcement-for-unstable/17574/132 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #513204. Please review diff with whitespaces off.
fetcherVersion = 1was kept around for backwards compatibility while callers migrated to2/3. With #494402 merged, only #513204 remains on master.This PR emits a
lib.warnIfwarning wheneverfetchPnpmDepsis called withfetcherVersion = 1, giving callers advance notice before the planned removal in 26.11. Per @Scrumplex's review the warning fires immediately on merge rather than being gated bylib.oldestSupportedReleaseIsAtLeast, since 26.05 will not include any packages withfetcherVersion = 1once #513204 lands.After 26.11 ships, a follow-up PR should drop
1fromsupportedFetcherVersionsand clean up the dead v1 branches indefault.nix,pnpm-config-hook.sh, andserve.nix.Things done