Skip to content

webkitgtk220x: drop#51296

Merged
jtojnar merged 1 commit intoNixOS:stagingfrom
jtojnar:webkitgtk-cleanup
Nov 30, 2018
Merged

webkitgtk220x: drop#51296
jtojnar merged 1 commit intoNixOS:stagingfrom
jtojnar:webkitgtk-cleanup

Conversation

@jtojnar
Copy link
Member

@jtojnar jtojnar commented Nov 30, 2018 •
edited
Loading

Motivation for this change

Follow-up to #45950 and #47949

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 30, 2018
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. and removed 6.topic: GNOME GNOME desktop environment and its underlying platform labels Nov 30, 2018
@jtojnar jtojnar added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 30, 2018
@jtojnar jtojnar merged commit 3a3513e into NixOS:staging Nov 30, 2018
@jtojnar jtojnar deleted the webkitgtk-cleanup branch December 1, 2018 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtojnar @GrahamcOfBorg