Skip to content

nvidia: expose nvidia_x11_legacy390#51294

Merged
veprbl merged 1 commit intoNixOS:masterfrom
eadwu:nvidia_x11/legacy_390
Dec 27, 2018
Merged

nvidia: expose nvidia_x11_legacy390#51294
veprbl merged 1 commit intoNixOS:masterfrom
eadwu:nvidia_x11/legacy_390

Conversation

@eadwu
Copy link
Member

@eadwu eadwu commented Nov 30, 2018

Motivation for this change

Closes #49679

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eadwu eadwu requested a review from infinisil as a code owner November 30, 2018 18:54
@eadwu eadwu mentioned this pull request Nov 30, 2018
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 30, 2018
@eadwu eadwu force-pushed the nvidia_x11/legacy_390 branch from 33339d2 to ea1be31 Compare November 30, 2018 18:58
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Nov 30, 2018
@jokogr jokogr mentioned this pull request Dec 9, 2018
11 tasks
@nek0
Copy link
Contributor

nek0 commented Dec 15, 2018

can somebody please speed up the process here? I would like to use this driver.

@eadwu
Copy link
Member Author

eadwu commented Dec 16, 2018

See #51768 (comment) if you don't use a local nixpkgs.

@nek0
Copy link
Contributor

nek0 commented Dec 16, 2018

thanks a lot. this worked.

@billksun
Copy link
Contributor

billksun commented Dec 21, 2018

@nek0 , what did you do to make it work?

I put this in my configuration.nix and it didn't do anything:

  nixpkgs.config = {
    allowUnfree = true;
    
    packageOverrides = super: let self = super.pkgs; in
    {
        linuxPackages = super.linuxPackages_latest.extend (self: super: {
          nvidiaPackages = super.nvidiaPackages // {
            stable = self.nvidiaPackages.stable_390;
          };
        });
    };
  }; 

@nek0
Copy link
Contributor

nek0 commented Dec 22, 2018

@sib-null You also need the following line in your configuration.

services.xserver.videoDrivers = [ "nvidia" ];

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@veprbl
Copy link
Member

veprbl commented Dec 27, 2018

@GrahamcOfBorg eval

@veprbl veprbl merged commit 3edd5cb into NixOS:master Dec 27, 2018
@eadwu eadwu deleted the nvidia_x11/legacy_390 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants