Skip to content

balsa: switch from enchant to gtkspell3#51254

Merged
hedning merged 1 commit intoNixOS:masterfrom
hedning:fix-balsa-enchant
Dec 4, 2018
Merged

balsa: switch from enchant to gtkspell3#51254
hedning merged 1 commit intoNixOS:masterfrom
hedning:fix-balsa-enchant

Conversation

@hedning
Copy link
Contributor

@hedning hedning commented Nov 29, 2018

Motivation for this change

The build fails with enchant-1.6.1 (upgrade is in #50876) and enchant2. use gtkspell3 instead.

cc maintainer @romildo

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The build fails with enchant-1.6.1 and enchant2. use gtkspell instead.
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 30, 2018

@GrahamcOfBorg eval

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 30, 2018
@romildo
Copy link
Contributor

romildo commented Nov 30, 2018

For curiosity I have looked at what other distributions opted for spell checking in balsa:

  • gspell: arch, debian, funtoo, macports, opensuse
  • gtkspell: dports, fedora, freshports, guix, gentoo

The gspell FAQ compares gspell and gtkspell.

@hedning hedning changed the base branch from staging-next to master November 30, 2018 17:52
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 30, 2018

@GrahamcOfBorg build balsa

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: balsa

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: balsa

Partial log (click to expand)

Wrapping program /nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6/bin/balsa
shrinking RPATHs of ELF executables and libraries in /nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6
shrinking /nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6/bin/.balsa-ab-wrapped
shrinking /nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6/bin/.balsa-wrapped
gzipping man pages under /nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6/share/man/
strip is /nix/store/6s8dkfj3irwv52cap2hd9k7gaddklfs1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6/bin
patching script interpreter paths in /nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6
checking for references to /build/ in /nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6...
/nix/store/94b2iwacc4g4a6l2hfsbdhw45nmj2w66-balsa-2.5.6

@hedning hedning merged commit af4e0db into NixOS:master Dec 4, 2018
@hedning hedning deleted the fix-balsa-enchant branch December 13, 2018 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants