Merged
Conversation
worldofpeace
suggested changes
Nov 22, 2018
Contributor
worldofpeace
left a comment
There was a problem hiding this comment.
A lot of the indentation and whitespace isn't up to par with what's in nixpkgs.
See: https://nixos.org/nixpkgs/manual/#sec-syntax
aanderse
reviewed
Nov 22, 2018
aanderse
reviewed
Nov 22, 2018
aanderse
reviewed
Nov 22, 2018
aanderse
reviewed
Nov 22, 2018
aanderse
reviewed
Nov 22, 2018
Contributor
Author
|
Whoopsie. Made a little git mess. Please disregard until I clean it up. |
4b9a6ff to
c70333e
Compare
c0bw3b
reviewed
Nov 23, 2018
c0bw3b
reviewed
Nov 23, 2018
c0bw3b
reviewed
Nov 23, 2018
c0bw3b
reviewed
Nov 24, 2018
nitpicks applied are:
- The pname thing
staging-next has been merged.
- Moved to tools/misc
applications/video is more appropriate for video applications.
This is a script used to interact with one.
- Changed platforms to unix
This script can only be used where kodi is present.
b117c74 to
0da6575
Compare
Contributor
|
@pstn I've pushed basically reviewer nitpicks to your branch. I hope you don't mind. Also, my apologies for your change being shelved on this |
Contributor
|
@GrahamcOfBorg build kodi-cli |
Contributor
Author
|
@worldofpeace All good! I actually made the same point about waiting with a merge for this package myself. I also like the nitpicks, just had a busy week and no time to merge. |
worldofpeace
approved these changes
Dec 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Added the handy utility
kodi-clifor controlling remote kodi instances with a cli.I was on the fence myself about PRing this, so I asked in #nixos. A few people wanted to have it, so here it is.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)