Merged
Conversation
emacs-overlay commit: dcd018dbd7b1cf0addf581f3aae39f3ca32d2a23
emacs-overlay commit: dcd018dbd7b1cf0addf581f3aae39f3ca32d2a23
…overlay) emacs-overlay commit: dcd018dbd7b1cf0addf581f3aae39f3ca32d2a23
emacs-overlay commit: dcd018dbd7b1cf0addf581f3aae39f3ca32d2a23
emacs-overlay commit: dcd018dbd7b1cf0addf581f3aae39f3ca32d2a23
panchoh
approved these changes
Apr 11, 2026
Contributor
panchoh
left a comment
There was a problem hiding this comment.
I’ve successfully reproduced your bump locally.
LGTM.
Details
$ cat verify-update-from-overlay-py #!/usr/bin/env bashset -euo pipefail
PR_ID="$1"
OVERLAY_COMMIT="$2"
git fetch origin pull/$PR_ID/head
git checkout $(git merge-base origin/master FETCH_HEAD)
git checkout -b reproduce/pr-$PR_ID
cd pkgs/applications/editors/emacs/elisp-packages
./update-from-overlay.py --commit "$OVERLAY_COMMIT"
git diff FETCH_HEAD
$ ./verify-update-from-overlay-py 508826 dcd018dbd7b1cf0addf581f3aae39f3ca32d2a23
AndersonTorres
approved these changes
Apr 11, 2026
Contributor
Author
|
I tested bumped pkgs in my Emacs and it seems good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.