Skip to content

meson: remove obsolete and blocking patch#50710

Merged
jtojnar merged 1 commit intoNixOS:stagingfrom
hedning:remove-obsolete-meson-patch
Nov 19, 2018
Merged

meson: remove obsolete and blocking patch#50710
jtojnar merged 1 commit intoNixOS:stagingfrom
hedning:remove-obsolete-meson-patch

Conversation

@hedning
Copy link
Contributor

@hedning hedning commented Nov 19, 2018

Motivation for this change

meson is now (in staging) upgraded to 0.48.2 which includes the patch causing the build to
fail.

The patch snuck in when merging #46020

cc @jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

meson is now upgraded to 0.48.2 which includes the patch causing the build to
fail.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 19, 2018
@jtojnar jtojnar merged commit dabc125 into NixOS:staging Nov 19, 2018
@jtojnar
Copy link
Member

jtojnar commented Nov 19, 2018

Thanks.

@hedning hedning deleted the remove-obsolete-meson-patch branch October 15, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants