qt59.qtwebkit: fix build on Darwin by alyssais · Pull Request #50521 · NixOS/nixpkgs

alyssais · 2018-11-17T20:08:39Z

Motivation for this change

Broken by #49768.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

LnL7 · 2018-11-17T20:10:15Z

Huh, I already fixed this.

LnL7 · 2018-11-17T20:11:01Z

#49845

alyssais · 2018-11-17T20:14:18Z

… huh.

Maybe I wasn't up to date when it was broken for me, and then since I changed it in a different place, git just combined the two when I updated.

alyssais · 2018-11-17T20:15:42Z

Oh, bet I know what it is! My fix would have propagated the cf-private dependency (bad), and that would have fixed qtwebkit, which is what I use qtbase for.

So what actually needs to happen is qtwebkit needs to depend on cf-private as well. I'll change the PR to do that.

LnL7 · 2018-11-17T20:32:06Z

Ah, I might have missed that. I tried to fix everything that's important to get master back in an ok state but looking into swift-corelibs is probably the proper solution.

GrahamcOfBorg · 2018-11-17T20:57:38Z

Success on aarch64-linux (full log)

Attempted: qt5.qtwebkit

Partial log (click to expand)

/nix/store/d4djagj6pwfh02rnhl7m7cnr4sfhyx9c-qtwebkit-5.212-alpha-01-26-2018

GrahamcOfBorg · 2018-11-17T20:57:42Z

Success on x86_64-linux (full log)

Attempted: qt5.qtwebkit

Partial log (click to expand)

copying path '/nix/store/w1g1g9qsbwnd9mv768gq0iahkah7x8x1-qtwebchannel-5.11.1' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/a83ibd3f6mdm744gq4r1pzgf1c2nw8cz-qtsvg-5.11.1-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/vf5cr6wgms6vzzjfwxg8b6w023jvf2di-qtxmlpatterns-5.11.1' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/72jbpg8xpqiy7vaj90q05v58g095hwd8-qtdeclarative-5.11.1-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/yi7m0sh0zsjj3xlncii0ik8h94fmn6ch-qtmultimedia-5.11.1-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/yf378rlvrkg889ypyl74xajqrdpvccwy-qtsensors-5.11.1-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/gnjs2iylshg30cdg53r7igvvmb9b470r-qtlocation-5.11.1-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/r8s2f07z14ynga40kk178bqg287gw3hz-qtwebchannel-5.11.1-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/14jr9wm6ch53q9sy3rabvdy5w6889b78-qtwebkit-5.212-alpha-01-26-2018' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/14jr9wm6ch53q9sy3rabvdy5w6889b78-qtwebkit-5.212-alpha-01-26-2018

alyssais · 2018-11-17T22:35:50Z

@LnL7 I just build this locally, and now it fails because it can't find CFURLCreateFromFSRef. It built fine with my previous commit. Any ideas?

LnL7 · 2018-11-17T23:02:48Z

@GrahamcOfBorg build qt5.qtwebkit

GrahamcOfBorg · 2018-11-17T23:03:07Z

Success on aarch64-linux (full log)

Attempted: qt5.qtwebkit

Partial log (click to expand)

/nix/store/d4djagj6pwfh02rnhl7m7cnr4sfhyx9c-qtwebkit-5.212-alpha-01-26-2018

GrahamcOfBorg · 2018-11-17T23:03:33Z

Success on x86_64-linux (full log)

Attempted: qt5.qtwebkit

Partial log (click to expand)

/nix/store/14jr9wm6ch53q9sy3rabvdy5w6889b78-qtwebkit-5.212-alpha-01-26-2018

GrahamcOfBorg · 2018-11-17T23:07:17Z

Failure on x86_64-darwin (full log)

Attempted: qt5.qtwebkit

Partial log (click to expand)

Call Stack (most recent call first):
  Source/cmake/WebKitCommon.cmake:50 (include)
  CMakeLists.txt:137 (include)


-- Configuring incomplete, errors occurred!
See also "/tmp/nix-build-qtwebkit-5.212-alpha-01-26-2018.drv-0/source/build/CMakeFiles/CMakeOutput.log".
See also "/tmp/nix-build-qtwebkit-5.212-alpha-01-26-2018.drv-0/source/build/CMakeFiles/CMakeError.log".
builder for '/nix/store/fyi69y54k76nlanr5zcc2fmyy270q1cv-qtwebkit-5.212-alpha-01-26-2018.drv' failed with exit code 1
error: build of '/nix/store/fyi69y54k76nlanr5zcc2fmyy270q1cv-qtwebkit-5.212-alpha-01-26-2018.drv' failed

alyssais · 2018-11-17T23:13:36Z

Oh, it'll need to be qt59.qtwebkit – it's the only Darwin-compatible version right now. See #48700.

GrahamcOfBorg · 2018-11-17T23:32:43Z

Success on aarch64-linux (full log)

Attempted: qt59.qtwebkit

Partial log (click to expand)

copying path '/nix/store/6ibm3ngqyx5xdwngrfpg29xfmb5im8s2-qtsvg-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/vamqvb5ax3lfvl66r0ll7wm71gajr4hk-qtxmlpatterns-5.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/3ihihxi137r0fhkhpgqx20rcy4azd6ym-qtdeclarative-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/p9r3702dcspvhp1zy7f6jb2dvpp1mx2n-qtlocation-5.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/yk1jq6c5vwlw91180aidc7kyw25blrrz-qtmultimedia-5.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/7f7zyg6i6ayzb76bqs35jj7jln0kkwcb-qtmultimedia-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/zmrj27l5c6bxrdk9x859kx1ngb9nqizj-qtsensors-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/iw7zfxnbzshgy2xm9iyzssv8h8jjqdx5-qtlocation-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/rmk32wsq9rhlwjpwf5g7h94gyb07gh8i-qtwebkit-5.9.1' from 'https://cache.nixos.org'...
/nix/store/rmk32wsq9rhlwjpwf5g7h94gyb07gh8i-qtwebkit-5.9.1

GrahamcOfBorg · 2018-11-17T23:32:50Z

Success on x86_64-linux (full log)

Attempted: qt59.qtwebkit

Partial log (click to expand)

copying path '/nix/store/2g26h6xmc25vk0fxwa18scjrlqrq7jvz-qtsvg-5.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/sdxi99k063l1dvqynbvxb27d4wmgrv4a-qtxmlpatterns-5.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/iv2ibwcpxn5f1m11cyxdmcr6xwgmskl1-qtsvg-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/si9wniy5av8ra8d6ilpfandffp722ldx-qtdeclarative-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/3yz1yc9jkym7kpfjxc524c04p6hffjv5-qtmultimedia-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/b2shangmjpz6jg1jbxq300q0mcpcnb12-qtsensors-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/ykvcj41214nyad2c61rxs7hykwiq9pwm-qtlocation-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/d1zl28xwlllm24cij4vnv2d30ngby56g-qtwebkit-5.9.1' from 'https://cache.nixos.org'...
cannot link '/nix/store/.links/0c7w99ryzk4s2ss6i8z3j54bhn4mpmqnaf1r50svzv5d7579xb6a' to '/nix/store/d1zl28xwlllm24cij4vnv2d30ngby56g-qtwebkit-5.9.1/lib/libQt5WebKit.prl': No space left on device
/nix/store/d1zl28xwlllm24cij4vnv2d30ngby56g-qtwebkit-5.9.1

LnL7 · 2018-11-18T10:37:00Z

@GrahamcOfBorg build qt59.qtwebkit

GrahamcOfBorg · 2018-11-18T10:37:15Z

Success on x86_64-linux (full log)

Attempted: qt59.qtwebkit

Partial log (click to expand)

copying path '/nix/store/p4b0avnpcvvj6b108zba9j61fgir5b2k-gtk+3-3.22.30' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/d13x5j7cmwj3y4jwwf2s3s40g45c954m-qtbase-5.9.3-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/iv2ibwcpxn5f1m11cyxdmcr6xwgmskl1-qtsvg-5.9.3-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/sdxi99k063l1dvqynbvxb27d4wmgrv4a-qtxmlpatterns-5.9.3' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/si9wniy5av8ra8d6ilpfandffp722ldx-qtdeclarative-5.9.3-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/3yz1yc9jkym7kpfjxc524c04p6hffjv5-qtmultimedia-5.9.3-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/b2shangmjpz6jg1jbxq300q0mcpcnb12-qtsensors-5.9.3-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/ykvcj41214nyad2c61rxs7hykwiq9pwm-qtlocation-5.9.3-bin' from 'https://nix-cache.s3.amazonaws.com'...
copying path '/nix/store/d1zl28xwlllm24cij4vnv2d30ngby56g-qtwebkit-5.9.1' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/d1zl28xwlllm24cij4vnv2d30ngby56g-qtwebkit-5.9.1

GrahamcOfBorg · 2018-11-18T10:37:18Z

Success on aarch64-linux (full log)

Attempted: qt59.qtwebkit

Partial log (click to expand)

copying path '/nix/store/6ibm3ngqyx5xdwngrfpg29xfmb5im8s2-qtsvg-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/vamqvb5ax3lfvl66r0ll7wm71gajr4hk-qtxmlpatterns-5.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/3ihihxi137r0fhkhpgqx20rcy4azd6ym-qtdeclarative-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/p9r3702dcspvhp1zy7f6jb2dvpp1mx2n-qtlocation-5.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/yk1jq6c5vwlw91180aidc7kyw25blrrz-qtmultimedia-5.9.3' from 'https://cache.nixos.org'...
copying path '/nix/store/7f7zyg6i6ayzb76bqs35jj7jln0kkwcb-qtmultimedia-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/zmrj27l5c6bxrdk9x859kx1ngb9nqizj-qtsensors-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/iw7zfxnbzshgy2xm9iyzssv8h8jjqdx5-qtlocation-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/rmk32wsq9rhlwjpwf5g7h94gyb07gh8i-qtwebkit-5.9.1' from 'https://cache.nixos.org'...
/nix/store/rmk32wsq9rhlwjpwf5g7h94gyb07gh8i-qtwebkit-5.9.1

GrahamcOfBorg · 2018-11-18T11:37:22Z

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: qt59.qtwebkit

Partial log (click to expand)

In file included from bindings/js/BindingState.h:35:
In file included from ../JavaScriptCore/runtime/Operations.h:28:
In file included from ../JavaScriptCore/runtime/JSFunctionInlines.h:29:
In file included from ../JavaScriptCore/runtime/Executable.h:39:
In file included from ../JavaScriptCore/parser/SourceCode.h:32:
../JavaScriptCore/parser/SourceProvider.h:58:18: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
            if (!this) // Be defensive in release mode.
                ~^~~~
building of '/nix/store/72cb2f4iv999ij52m2cb3bz56k45z6f7-qtwebkit-5.9.1.drv' timed out after 3600 seconds
error: build of '/nix/store/72cb2f4iv999ij52m2cb3bz56k45z6f7-qtwebkit-5.9.1.drv' failed

LnL7 · 2018-11-19T20:15:54Z

@alyssais Does this latest commit work for you? I had a successful build.

alyssais · 2018-11-21T13:32:45Z

Yep, this works for me.

timokau · 2018-12-21T13:56:42Z

Not sure if this is related, but qtwebkit currently fails for darwin: https://github.com/NixOS/nixpkgs/pull/52613/checks?check_run_id=43642188

timokau · 2018-12-21T13:57:42Z

Looks like that is already #51846

veprbl · 2018-12-21T14:48:30Z

@timokau
The name attribute for our qtwebkit is a bit confusing. So qt59.qtwebkit does build [1], but qt511.qtwebkit is used by pyqt5 and it is broken [2]. I expect that it will become harder and harder to maintain working qtwebkit in the future. The #51846 is a step towards phasing out QtWebKit from the python applications.

[1] https://hydra.nixos.org/job/nixpkgs/trunk/qt59.qtwebkit.x86_64-darwin
[2] https://hydra.nixos.org/job/nixpkgs/trunk/qt511.qtwebkit.x86_64-darwin

alyssais requested a review from ttuegel as a code owner November 17, 2018 20:08

alyssais force-pushed the qt-cf-private branch from 30b28de to d89a2a2 Compare November 17, 2018 20:19

alyssais changed the title ~~qt5.qtbase: fix build on Darwin~~ qt5.qtwebkit: fix build on Darwin Nov 17, 2018

GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Nov 17, 2018

GrahamcOfBorg added 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Nov 17, 2018

qt59.qtwebkit: fix build on Darwin

874468f

alyssais force-pushed the qt-cf-private branch from d89a2a2 to 874468f Compare November 17, 2018 23:18

alyssais changed the title ~~qt5.qtwebkit: fix build on Darwin~~ qt59.qtwebkit: fix build on Darwin Nov 17, 2018

Mic92 merged commit 7f2c30f into NixOS:master Nov 21, 2018

alyssais deleted the qt-cf-private branch November 22, 2018 11:37

Uh oh!

Conversation

alyssais commented Nov 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

LnL7 commented Nov 17, 2018

Uh oh!

LnL7 commented Nov 17, 2018

Uh oh!

alyssais commented Nov 17, 2018

Uh oh!

alyssais commented Nov 17, 2018

Uh oh!

LnL7 commented Nov 17, 2018

Uh oh!

GrahamcOfBorg commented Nov 17, 2018

Uh oh!

GrahamcOfBorg commented Nov 17, 2018

Uh oh!

alyssais commented Nov 17, 2018

Uh oh!

LnL7 commented Nov 17, 2018

Uh oh!

GrahamcOfBorg commented Nov 17, 2018

Uh oh!

GrahamcOfBorg commented Nov 17, 2018

Uh oh!

GrahamcOfBorg commented Nov 17, 2018

Uh oh!

alyssais commented Nov 17, 2018

Uh oh!

GrahamcOfBorg commented Nov 17, 2018

Uh oh!

GrahamcOfBorg commented Nov 17, 2018

Uh oh!

LnL7 commented Nov 18, 2018

Uh oh!

GrahamcOfBorg commented Nov 18, 2018

Uh oh!

GrahamcOfBorg commented Nov 18, 2018

Uh oh!

GrahamcOfBorg commented Nov 18, 2018

Uh oh!

LnL7 commented Nov 19, 2018

Uh oh!

alyssais commented Nov 21, 2018

Uh oh!

timokau commented Dec 21, 2018

Uh oh!

timokau commented Dec 21, 2018

Uh oh!

veprbl commented Dec 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

alyssais commented Nov 17, 2018 •

edited

Loading

veprbl commented Dec 21, 2018 •

edited

Loading