Skip to content

nixos-functions: remove recurseIntoAttrs #50405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Mic92 wants to merge 1 commit into from
Closed

nixos-functions: remove recurseIntoAttrs #50405

Mic92 wants to merge 1 commit into from

Conversation

@Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 15, 2018 •
edited
Loading

This prevents from tooling like nix-review/nox-review from trying to build those.
Also we probably don't want to evaluate nixos when updating the nix search index.
Hopefully also fix NixOS/ofborg#269

@Mic92
nixos-functions: remove recurseIntoAttrs
fe3a8d5 
This prevents from tooling like nix-review/nox-review from trying to build those.
Also we probably don't want to evaluate nixos when updating the nix search index.
@Mic92 Mic92 requested review from edolstra and roberth November 15, 2018 15:03
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 15, 2018
@edolstra
Copy link
Member

edolstra commented Nov 15, 2018

I think the real issue is that pkgs/test should not be included from all-packages.nix.

@edolstra edolstra mentioned this pull request Nov 15, 2018
Merged
9 tasks
@Mic92
Copy link
Member Author

Mic92 commented Nov 19, 2018

I worked around in nix-review.

@Mic92 Mic92 closed this Nov 19, 2018
@Mic92 Mic92 deleted the nixos-tests branch November 19, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth Awaiting requested review from roberth

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

eval gist contains tests.nixos-functions.nixos-test in change attrset

3 participants

@Mic92 @edolstra @GrahamcOfBorg