Skip to content

androidsdk: fix emulator#50276

Merged
Mic92 merged 2 commits intoNixOS:masterfrom
corngood:android-emulator-fix
Nov 12, 2018
Merged

androidsdk: fix emulator#50276
Mic92 merged 2 commits intoNixOS:masterfrom
corngood:android-emulator-fix

Conversation

@corngood
Copy link
Contributor

Motivation for this change

See #49515, #50263

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@corngood
Copy link
Contributor Author

I've been using the emulator successfully for a couple of days, but more testing would be appreciated.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 12, 2018
@Mic92 Mic92 merged commit 968b20e into NixOS:master Nov 12, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 12, 2018

I guess we can merge this for now if it is an improvement over the current state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants