linux: enable CGROUP_HUGETLB, CGROUP_PERF, CGROUP_RDMA by orivej · Pull Request #50225 · NixOS/nixpkgs

orivej · 2018-11-11T07:51:10Z

Motivation for this change

CGROUP_PERF is needed for gVisor with Docker: #50218

Affected options were added in these Linux releases:

NAMESPACES 2.6.25
CGROUP_DEVICE 2.6.26
CGROUP_HUGETLB 3.6
CGROUP_PERF 2.6.39
CGROUP_RDMA 4.11

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

/cc @andrew-d

GrahamcOfBorg · 2018-11-11T08:04:05Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linux

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14351:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14351:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14649:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14649:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:51:1

These options were added in: NAMESPACES 2.6.25 CGROUP_DEVICE 2.6.26 CGROUP_HUGETLB 3.6 CGROUP_PERF 2.6.39 CGROUP_RDMA 4.11

GrahamcOfBorg · 2018-11-11T08:20:08Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linux

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14284:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14284:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14589:16, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:14589:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:51:1

GrahamcOfBorg · 2018-11-11T08:20:52Z

Success on aarch64-linux (full log)

Attempted: linux

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/gbk7nyph15xh2qbchd1i7iqiigk09ki6-linux-4.14.80

GrahamcOfBorg · 2018-11-11T08:24:24Z

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: linux

Partial log (click to expand)

warning: unused option: X86_INTEL_PSTATE
warning: unused option: X86_MCE
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/179jgv0h2p3lhasyhrhnfpi9c495xkxf-linux-config-4.14.79
strip is /nix/store/426i2d272x6c8j4shwl1377xj2cf1ijj-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/179jgv0h2p3lhasyhrhnfpi9c495xkxf-linux-config-4.14.79
checking for references to /build in /nix/store/179jgv0h2p3lhasyhrhnfpi9c495xkxf-linux-config-4.14.79...
cannot build derivation '/nix/store/jl0bh04z5qwkwpnynlz94nxv4byk936c-linux-4.14.79.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jl0bh04z5qwkwpnynlz94nxv4byk936c-linux-4.14.79.drv' failed

GrahamcOfBorg · 2018-11-11T08:25:29Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: linux

Partial log (click to expand)

warning: unused option: RUNTIME_TESTING_MENU
warning: unused option: USB_DEBUG
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/x9shjj6p1ifsnaq9xal9g80zl5r5ic5f-linux-config-4.14.79
strip is /nix/store/xzn29jrdk6czmx5qai15v6hwsrxviw4c-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/x9shjj6p1ifsnaq9xal9g80zl5r5ic5f-linux-config-4.14.79
checking for references to /build in /nix/store/x9shjj6p1ifsnaq9xal9g80zl5r5ic5f-linux-config-4.14.79...
cannot build derivation '/nix/store/pgvk1skc10ra55l60s2js6ygn8fivkqp-linux-4.14.79.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pgvk1skc10ra55l60s2js6ygn8fivkqp-linux-4.14.79.drv' failed

GrahamcOfBorg · 2018-11-11T08:29:21Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: linux

Partial log (click to expand)

while evaluating the attribute 'linux_4_14' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14284:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14284:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
while evaluating 'buildLinux' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14589:16, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/linux-4.14.nix:5:1:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:108:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/top-level/all-packages.nix:14589:23:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:67:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:112:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/lib/customisation.nix:69:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndndx-vm/pkgs/os-specific/linux/kernel/generic.nix:51:1

GrahamcOfBorg · 2018-11-11T08:29:51Z

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: linux

Partial log (click to expand)

gzipping man pages under /nix/store/s1b3ydqc08br7rn13vn2ilj1isrcvlqr-bc-1.07.1/share/man/
strip is /nix/store/426i2d272x6c8j4shwl1377xj2cf1ijj-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/s1b3ydqc08br7rn13vn2ilj1isrcvlqr-bc-1.07.1/bin
/nix/store/hgyjgr5bzjlxgni3brpzkdpsdq7rzrz1-patch-shebangs.sh: line 105: [: missing `]'
patching script interpreter paths in /nix/store/s1b3ydqc08br7rn13vn2ilj1isrcvlqr-bc-1.07.1
checking for references to /build in /nix/store/s1b3ydqc08br7rn13vn2ilj1isrcvlqr-bc-1.07.1...
output '/nix/store/s1b3ydqc08br7rn13vn2ilj1isrcvlqr-bc-1.07.1' is not allowed to refer to the following paths:
  /nix/store/4gbglwv7an4vjicfv2mc9a43v3h52pgd-flex-2.6.4
cannot build derivation '/nix/store/jl0bh04z5qwkwpnynlz94nxv4byk936c-linux-4.14.79.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jl0bh04z5qwkwpnynlz94nxv4byk936c-linux-4.14.79.drv' failed

GrahamcOfBorg · 2018-11-11T08:33:59Z

Unexpected error: command failed with exit code 1 on x86_64-linux (full log)

Attempted: linux

Partial log (click to expand)

warning: unused option: RUNTIME_TESTING_MENU
warning: unused option: USB_DEBUG
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/x9shjj6p1ifsnaq9xal9g80zl5r5ic5f-linux-config-4.14.79
strip is /nix/store/xzn29jrdk6czmx5qai15v6hwsrxviw4c-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/x9shjj6p1ifsnaq9xal9g80zl5r5ic5f-linux-config-4.14.79
checking for references to /build in /nix/store/x9shjj6p1ifsnaq9xal9g80zl5r5ic5f-linux-config-4.14.79...
cannot build derivation '/nix/store/pgvk1skc10ra55l60s2js6ygn8fivkqp-linux-4.14.79.drv': 1 dependencies couldn't be built
error: build of '/nix/store/pgvk1skc10ra55l60s2js6ygn8fivkqp-linux-4.14.79.drv' failed

GrahamcOfBorg · 2018-11-11T08:38:45Z

Timed out, unknown build status on x86_64-linux (full log)

Attempted: linux

Partial log (click to expand)

  CC [M]  drivers/usb/chipidea/ci_hdrc_zevio.o
  CC [M]  drivers/staging/vboxvideo/vbox_mode.o
  CC [M]  drivers/usb/chipidea/ci_hdrc_pci.o
  CC [M]  drivers/staging/vboxvideo/vbox_prime.o
  CC      drivers/tty/serial/earlycon.o
  LD [M]  drivers/usb/chipidea/ci_hdrc.o
  AR      drivers/usb/class/built-in.o
  CC [M]  drivers/usb/class/cdc-acm.o
building of '/nix/store/amljvqx27m2r7p2aw05if3qnkc65b5v8-linux-4.14.80.drv' timed out after 1800 seconds
error: build of '/nix/store/amljvqx27m2r7p2aw05if3qnkc65b5v8-linux-4.14.80.drv' failed

…#50225)" This reverts commit 08d98b2.

NixOS#50225)"" This reverts commit b67b3af.

These options were added in: NAMESPACES 2.6.25 CGROUP_DEVICE 2.6.26 CGROUP_HUGETLB 3.6 CGROUP_PERF 2.6.39 CGROUP_RDMA 4.11 (cherry picked from commit 08d98b2)

GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 11, 2018

linux: enable CGROUP_HUGETLB, CGROUP_PERF, CGROUP_RDMA

96bb280

These options were added in: NAMESPACES 2.6.25 CGROUP_DEVICE 2.6.26 CGROUP_HUGETLB 3.6 CGROUP_PERF 2.6.39 CGROUP_RDMA 4.11

orivej changed the base branch from master to staging November 11, 2018 08:07

orivej force-pushed the cgroup branch from 712b643 to 96bb280 Compare November 11, 2018 08:07

matthewbauer approved these changes Nov 11, 2018

View reviewed changes

andrew-d mentioned this pull request Nov 12, 2018

gvisor: init at 2018-11-10 #50218

Closed

9 tasks

orivej-nixos merged commit 08d98b2 into NixOS:staging Nov 13, 2018

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Dec 4, 2018

Revert "linux: enable CGROUP_HUGETLB, CGROUP_PERF, CGROUP_RDMA (NixOS…

b67b3af

…#50225)" This reverts commit 08d98b2.

dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Dec 4, 2018

Revert "Revert "linux: enable CGROUP_HUGETLB, CGROUP_PERF, CGROUP_RDMA (

4a4a44c

NixOS#50225)"" This reverts commit b67b3af.

orivej deleted the cgroup branch March 29, 2023 20:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

linux: enable CGROUP_HUGETLB, CGROUP_PERF, CGROUP_RDMA#50225

linux: enable CGROUP_HUGETLB, CGROUP_PERF, CGROUP_RDMA#50225
orivej-nixos merged 1 commit intoNixOS:stagingfrom
orivej:cgroup

orivej commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

orivej commented Nov 11, 2018

Motivation for this change

Things done

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

GrahamcOfBorg commented Nov 11, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants