nixos/test-driver: fix type hints in extract-docstrings#501294
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Mar 19, 2026
Merged
nixos/test-driver: fix type hints in extract-docstrings#501294vcunat merged 1 commit intoNixOS:staging-nextfrom
vcunat merged 1 commit intoNixOS:staging-nextfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the NixOS test-driver docstring extraction helper to use modern Python type-hint syntax, aligning it with the project’s existing Python (3.10+) typing style and resolving type-hint inconsistencies.
Changes:
- Remove the unused
typing.Listimport. - Replace
List[...]annotations with built-in genericslist[...]in function signatures.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
13 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
|
Now it's failing on |
kmein
force-pushed
the
fix/extract-docstrings
branch
from
6c3bf76 to
fba7fb2
Compare
Member
|
Diff looks good and that build is fixed now. |
auto-merge was automatically disabled
March 19, 2026 12:55
Head branch was pushed to by a user without write access
kmein
force-pushed
the
fix/extract-docstrings
branch
from
fba7fb2 to
f7e8f0c
Compare
Member
Author
|
@vcunat Can you reenable automerge? Had to throw out an accidentally committed file. |
Merged
via the queue into
NixOS:staging-next
with commit Mar 19, 2026
fd3a085
27 of 30 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fixup for #479968.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.