Skip to content

rust: 1.30.0 -> 1.30.1#50006

Merged
Mic92 merged 1 commit intoNixOS:stagingfrom
alyssais:rust-1.30.1
Nov 14, 2018
Merged

rust: 1.30.0 -> 1.30.1#50006
Mic92 merged 1 commit intoNixOS:stagingfrom
alyssais:rust-1.30.1

Conversation

@alyssais
Copy link
Member

@alyssais alyssais commented Nov 9, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested review from LnL7 and Mic92 as code owners November 9, 2018 09:56
@GrahamcOfBorg GrahamcOfBorg added 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 9, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 12, 2018

Can you change this update to point to staging?

@alyssais alyssais changed the base branch from master to staging November 12, 2018 20:18
# Note: the version MUST be one version prior to the version we're
# building
version = "1.29.2";
version = "1.30.0";
Copy link
Member

@Mic92 Mic92 Nov 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grahamc one major version? You said people from #rust told you that.

Copy link
Member

@grahamc grahamc Nov 13, 2018 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know either, but I think we've been doing minor releases.

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2018

tested on aarch64

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

tested on x86_64.

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

@LnL7 can we get a macOS build?

@LnL7
Copy link
Member

LnL7 commented Nov 14, 2018

Hmm, staging is completely broken. 😕

@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

@alyssais did you were able to build this on master with maybe one package like fd on macOS?

@alyssais
Copy link
Member Author

@Mic92 I've just cherry-picked onto current master and kicked off a build. Will report back.

@alyssais
Copy link
Member Author

I've successfully built fd on Darwin with this patch applied to master.

@Mic92 Mic92 merged commit 9e39329 into NixOS:staging Nov 14, 2018
@Mic92
Copy link
Member

Mic92 commented Nov 14, 2018

It think this should be enough testing for a patch release.

@LnL7
Copy link
Member

LnL7 commented Nov 14, 2018

My builds targeting master also succeeded, currently testing some reverts for staging so hopefully that's in a better spot soon.

@alyssais alyssais deleted the rust-1.30.1 branch November 22, 2018 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants