networkmanager-l2tp: hoist pname attribute#49731
Closed
danieldk wants to merge 1 commit intoNixOS:masterfrom
Closed
networkmanager-l2tp: hoist pname attribute#49731danieldk wants to merge 1 commit intoNixOS:masterfrom
danieldk wants to merge 1 commit intoNixOS:masterfrom
Conversation
Since NixOS#49398 was merged, name should have pname as a suffix, however this derivation adds '-gnome' as a suffix when it is built with GNOME support. This change makes the derivation more similar to some other Network Manager plugins, where pname is not an attribute.
Member
|
#49398 was reverted until we have a fix for all evaluation errors. |
Contributor
Author
|
@Mic92 indeed, I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since #49398 was merged, name should have pname as a suffix, however
this derivation adds '-gnome' as a suffix when it is built with GNOME
support. This change makes the derivation more similar to some other
Network Manager plugins, where pname is not an attribute.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)