Skip to content

pdfding: 1.5.1 -> 1.7.1#496164

Merged
imincik merged 2 commits into
NixOS:masterfrom
phanirithvij:pdfding-upd
Apr 1, 2026
Merged

pdfding: 1.5.1 -> 1.7.1#496164
imincik merged 2 commits into
NixOS:masterfrom
phanirithvij:pdfding-upd

Conversation

@phanirithvij
Copy link
Copy Markdown
Member

@phanirithvij phanirithvij commented Mar 3, 2026 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in
    ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and
    other READMEs.

@phanirithvij phanirithvij mentioned this pull request Mar 3, 2026
Open
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 3, 2026
@phanirithvij phanirithvij marked this pull request as ready for review March 3, 2026 10:39
@wegank
Copy link
Copy Markdown
Member

wegank commented Mar 3, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 496164
Commit: 04d89e0fc83b8f7ade1faf816a60204090c797b2

aarch64-darwin

✅ 2 packages built:
  • pdfding
  • pdfding.dist

@phanirithvij phanirithvij marked this pull request as draft March 3, 2026 11:10
@nixpkgs-ci nixpkgs-ci Bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Mar 3, 2026
@phanirithvij

This comment was marked as duplicate.

Sign in to view
@phanirithvij phanirithvij changed the title pdfding: 1.5.1 -> 1.6.1 pdfding: 1.5.1 -> 1.6.3 Mar 23, 2026
@phanirithvij phanirithvij marked this pull request as ready for review March 23, 2026 14:06
@phanirithvij

This comment was marked as outdated.

Sign in to view
@phanirithvij

This comment was marked as outdated.

Sign in to view
@phanirithvij
Copy link
Copy Markdown
Member Author

phanirithvij commented Mar 23, 2026

e2e tests are not able to run on github actions runners, not powerful enough.

Ran it locally and it is fine. /nix/store/0nydbqc4jdmnwkqama2d5pm92s43vqis-vm-test-run-PdfDing-e2e-tests

@phanirithvij
Copy link
Copy Markdown
Member Author

phanirithvij commented Mar 23, 2026

@ofborg test pdfding

@phanirithvij
pdfding: 1.5.1 -> 1.6.3
c5dbcec 
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
@phanirithvij
pdfding: 1.6.3 -> 1.7.1
9e035fe 
Signed-off-by: phanirithvij <phanirithvij2000@gmail.com>
@phanirithvij phanirithvij changed the title pdfding: 1.5.1 -> 1.6.3 pdfding: 1.5.1 -> 1.7.1 Apr 1, 2026
@phanirithvij phanirithvij added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 1, 2026
@phanirithvij phanirithvij requested a review from imincik April 1, 2026 08:47
@phanirithvij
Copy link
Copy Markdown
Member Author

phanirithvij commented Apr 1, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 496164 -p pdfding -p pdfding.passthru.tests.basic -p pdfding.passthru.tests.s3-backups -p pdfding.passthru.tests.postgres
Commit: 9e035fef4004e4a6fae9c30a6de6e7faa6f85255 (subsequent changes)
Merge: 0b0495bc5bb2b9924e5385147ffe71b7f118cec4

Logs: https://github.com/phanirithvij/nixpkgs-review-gha/actions/runs/23840553115

x86_64-linux

✅ 5 packages built:
  • pdfding
  • pdfding.dist (pdfding.dist.dist)
  • pdfding.passthru.tests.basic
  • pdfding.passthru.tests.postgres
  • pdfding.passthru.tests.s3-backups

aarch64-linux

✅ 5 packages built:
  • pdfding
  • pdfding.dist (pdfding.dist.dist)
  • pdfding.passthru.tests.basic
  • pdfding.passthru.tests.postgres
  • pdfding.passthru.tests.s3-backups

eljamm
eljamm approved these changes Apr 1, 2026
View reviewed changes
Comment thread pkgs/by-name/pd/pdfding/frontend.nix
Comment on lines +30 to 36
version = "1.7.1";
src = fetchFromGitHub {
owner = "mrmn2";
repo = "PdfDing";
tag = "v${finalAttrs.version}";
hash = "sha256-PXkD+2k8/LmMWzZAj8qEK4mLoOKS4mDWcqe8AgoCdBU=";
hash = "sha256-T3Y9eWwBVxGPISZ3EZndAR6mwsq4g67RRCPpoZPuh+0=";
};
Copy link
Copy Markdown
Contributor

@eljamm eljamm Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could inherit these from the main package.

Copy link
Copy Markdown
Member Author

@phanirithvij phanirithvij Apr 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update the update script as well, let's merge it for now as it is a security fix. I will rework it later.

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Apr 1, 2026
@phanirithvij
Copy link
Copy Markdown
Member Author

phanirithvij commented Apr 1, 2026

e2e tests pass on ngi-nix makemake https://buildbot.ngi.nixos.org/#/builders/1353/builds/312

imincik
imincik approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Phani. Looks good.

@imincik imincik enabled auto-merge April 1, 2026 10:08
@imincik imincik disabled auto-merge April 1, 2026 10:09
@imincik imincik merged commit aa2c796 into NixOS:master Apr 1, 2026
34 of 38 checks passed
@phanirithvij phanirithvij deleted the pdfding-upd branch April 1, 2026 10:11
@phanirithvij phanirithvij mentioned this pull request Apr 3, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imincik imincik imincik approved these changes

@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

@Prince213 Prince213 Awaiting requested review from Prince213

@wegank wegank Awaiting requested review from wegank

+1 more reviewer

@eljamm eljamm eljamm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PdfDing: Shared PDF Expiration, Max Views, and Deletion Bypass via Serve/Download Endpoints

4 participants

@phanirithvij @wegank @imincik @eljamm