Restore cross-patch-shebangs branch#49608
Conversation
|
cc @LnL7 |
11edcdd to
21a236d
Compare
|
@GrahamcOfBorg build stdenv |
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Timed out, unknown build status on x86_64-darwin (full log) Attempted: stdenv Partial log (click to expand)
|
pkgs/stdenv/darwin/default.nix
Outdated
There was a problem hiding this comment.
Edit this comment to match the new reality, too? I also feel like if we can use your disallowRequisites patch with this, we can skip pkgs.bash in either list, which would be best. I'd be very down to collaborate getting all the stdenv deps to use strictDeps :).
There was a problem hiding this comment.
Yeah that sounds good! It might have to go in another PR for now - I'm more worried about fixing cross compilation right now.
One thing these are all going to need though is bash in the buildInputs. I think there's quite a few of those that don't have it right now.
I think we could also do an override here that does something like:
stdenv = super.stdenv // { mkDerivation = args: super.stdenv.mkDerivation (args // { strictDeps = true; }); };
To avoid individually setting all of these.
There was a problem hiding this comment.
Well I do want to audit those packages anyways. I think I've decided this PR and the disallowRequites one are good as is, and then all the per-package cleanup can happen in a 3rd PR.
This reverts commit 9c4b11e.
In strictDeps=false, autoPatchshebangs should use --build (corresponding to PATH) to lookup commands. This restores the previous behavior of patchshebangs so that we don’t break stuff that isn’t careful in the buildInputs vs. nativeBuildInputs distinction. Unfortunately this won’t work under cross compilation.
patch shebangs needs to be in build inputs for it to get into HOST_PATH.
21a236d to
068db20
Compare
068db20 to
2f2e635
Compare
Motivation for this change
This was merged, then reverted. This should address the issues that originally came up.