Skip to content

coreutils: fix SIGHUP in certain flaky tests#495372

Merged
mdaniels5757 merged 1 commit intoNixOS:stagingfrom
mdaniels5757:coreutils-add-test-fix-patch
Mar 2, 2026
Merged

coreutils: fix SIGHUP in certain flaky tests#495372
mdaniels5757 merged 1 commit intoNixOS:stagingfrom
mdaniels5757:coreutils-add-test-fix-patch

Conversation

@mdaniels5757
Copy link
Member

Context: https://github.com/NixOS/nixpkgs/pull/487081#issuecomment-3868051076 and ensuing discussion
Context: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=80477

Fixes: #495290

Cc: @chrisheib

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot requested a review from dasJ March 1, 2026 01:04
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Mar 1, 2026
Copy link
Contributor

@uninsane uninsane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes coreutils build, including coreutils.override { singleBinary = true; }, coreutils.override { singleBinary = "shebangs"; }

@mdaniels5757 mdaniels5757 force-pushed the coreutils-add-test-fix-patch branch from dc9052b to 883dfc9 Compare March 2, 2026 22:28
@mdaniels5757 mdaniels5757 enabled auto-merge March 2, 2026 22:28
@mdaniels5757 mdaniels5757 force-pushed the coreutils-add-test-fix-patch branch from 883dfc9 to 818e8ba Compare March 2, 2026 22:29
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 2, 2026
@mdaniels5757 mdaniels5757 added this pull request to the merge queue Mar 2, 2026
Merged via the queue into NixOS:staging with commit e4fc6b6 Mar 2, 2026
45 of 46 checks passed
@mdaniels5757 mdaniels5757 deleted the coreutils-add-test-fix-patch branch March 2, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants