Merged
Conversation
jtojnar
requested changes
Oct 30, 2018
c230876 to
5c1b8a5
Compare
Contributor
Author
|
Thanks for reviews. I think I applied all requested changes |
Contributor
|
@GrahamcOfBorg build cmusfm |
|
Success on aarch64-linux (full log) Attempted: cmusfm Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: cmusfm Partial log (click to expand)
|
jtojnar
reviewed
Oct 31, 2018
5c1b8a5 to
c8c7747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is a program wich allows scrobbling from cmus to the audioscrobbler API of Last.FM and Libre.FM. I use it to keep trace of my listening habits. It may help cmus users to scrobble their songs.
The configuration is explained in the meta.longDescription field and on the project repository.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)