Conversation
ed5768c to
9bee736
Compare
9bee736 to
70ebf7a
Compare
70ebf7a to
0da277f
Compare
0da277f to
5ef4b67
Compare
f37d59c to
a87df13
Compare
a87df13 to
0903777
Compare
4be1157 to
bd49f5b
Compare
bd49f5b to
bd6b474
Compare
bd6b474 to
9fcb084
Compare
9fcb084 to
e117caf
Compare
glittershark
left a comment
There was a problem hiding this comment.
code LGTM, though I would like a maintainer to look at it as well.
Also, looks like you need to rebase -i --autosquash
5995231 to
1f951b6
Compare
|
Thanks. I've squashed the commits. |
timokau
left a comment
There was a problem hiding this comment.
The remaining nits are so minor that I don't want to hold this up even longer over them. Great work!
There was a problem hiding this comment.
pkgs.writeText didn't actually write anything without the newline.
|
Oh, actually needs a rebase anyway. Would it be possible to do the node update and the epgstation update in separate commits? Not really important though if its a lot of effort. |
|
Unfortunately it can't. All node packages would have to be upgraded simultaneously. I'll just do a rebase now. |
and improve documentation along the way
1f951b6 to
36c16fa
Compare
|
rebased :-) |
At least for vim plugins, the way we usually handle new inclusions is first update all existing packages, then add the new package and run another "update" (which will then only add the new package). Anyway, not very important. Thank you for your patience and the great work here! |
Motivation for this change
EPGStation is a DVR software for ISDB television. This depends on #48740.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)