libsoup_3: drop patches incorporated in 3.6.6#493918
Merged
vcunat merged 1 commit intoNixOS:stagingfrom Feb 25, 2026
Merged
Conversation
This package currently fails to build during the patch application step as it includes patches that were incorporated into libsoup 3.6.6. These patches were introduced in NixOS#468891 and NixOS#489681. Since they are now part of a regular release, we thus drop these patches. The List of commits where these changes are present can be seen at https://gitlab.gnome.org/GNOME/libsoup/-/compare/3.6.5...3.6.6.
nixpkgs-ci
bot
requested review from
a team,
7c6f434c,
bobby285271,
dasj19,
hedning,
jtojnar and
lovek323
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
Member
|
I just found this problem on |
Member
|
I had identical diff before discovering your PR, but I'm taking the PR now + backport in 9812196 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package currently fails to build during the patch application step as it includes patches that were incorporated into libsoup 3.6.6. These patches were introduced in #468891 and #489681. Since they are now part of a regular release (which we already have on both staging and staging-next-25.11), we thus drop these patches.
The list of commits where these changes are present can be seen at https://gitlab.gnome.org/GNOME/libsoup/-/compare/3.6.5...3.6.6.
This has not been tested on staging, as I don't have the compute to build up from stdenv.However, I have tested this build on both x86_64-linux and aarch64-linux by picking this commit on top of staging-next-25.11. It is currently failing there, and succeeds after this commit.Edit: Nevermind, I let it run overnight and
libsoup_3successfully built for x86_64-linux on top of staging.I'm not sure how to mark this for backport to staging-next-25.11, since there's not a label to do so. However, that backport should happen.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.