Skip to content

cctools: bump to latest commit#49371

Merged
matthewbauer merged 1 commit intoNixOS:stagingfrom
matthewbauer:cctools-bump
Oct 29, 2018
Merged

cctools: bump to latest commit#49371
matthewbauer merged 1 commit intoNixOS:stagingfrom
matthewbauer:cctools-bump

Conversation

@matthewbauer
Copy link
Member

Lots of our patches are no longer needed. This simplifies things a
bunch. In addition, it now includes man pages.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Lots of our patches are no longer needed. This simplifies things a
bunch. In addition, it now includes man pages.
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 28, 2018
@LnL7
Copy link
Member

LnL7 commented Oct 28, 2018

Nice, I was also thinking about doing this. Do you know if this fixes nm on 10.14?

$ nm /usr/lib/libSystem.B.dylib
nm: for architecture x86_64 object: /usr/lib/libSystem.B.dylib malformed object (unknown load command 8)

@matthewbauer
Copy link
Member Author

matthewbauer commented Oct 28, 2018

No, we'll need apple to release the new tools for that.

tpoechtrager/cctools-port#60

@matthewbauer matthewbauer changed the base branch from master to staging October 29, 2018 00:05
@matthewbauer matthewbauer merged commit bda626e into NixOS:staging Oct 29, 2018
@Ericson2314
Copy link
Member

Ericson2314 commented Oct 29, 2018

For iOS we sadly need the old version until either https://lists.llvm.org/pipermail/llvm-dev/2017-September/117264.html is done or we package Apple's LLVM fork. CC @kmicklas. There are some more recent responses to this post in ~August.

@matthewbauer
Copy link
Member Author

Oops! I thought we fixed that one. Have you seen this:

https://github.com/tpoechtrager/apple-libtapi

?

@Ericson2314
Copy link
Member

Doesn't that still contain much vendored LLVM?

@matthewbauer matthewbauer deleted the cctools-bump branch February 22, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants