Skip to content

qt6.qtbase: fix package reference in setup hook#493437

Closed
mjoerg wants to merge 1 commit intoNixOS:stagingfrom
mjoerg:qt6-qtbase-fix-hook
Closed

qt6.qtbase: fix package reference in setup hook#493437
mjoerg wants to merge 1 commit intoNixOS:stagingfrom
mjoerg:qt6-qtbase-fix-hook

Conversation

@mjoerg
Copy link
Contributor

@mjoerg mjoerg commented Feb 23, 2026

After ceec85b, @out@ incorrectly referenced the setup hook instead of the actual package.

fixes #493843

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Feb 23, 2026
After ceec85b, `@out@` incorrectly referenced the setup hook instead of the actual package.
@mjoerg mjoerg force-pushed the qt6-qtbase-fix-hook branch from bbac16c to cf10b6f Compare February 23, 2026 21:09
@mjoerg mjoerg requested a review from SFrijters February 25, 2026 08:44
@SFrijters
Copy link
Member

Seems I was going in the same direction with my fix, but with a slightly different implementation: #493988 . I prefer that one because your solution moves away from the compatibility with __structuredAttrs and reliance on substituteAll that the original PR was trying to accomplish.

makeSetupHook needs some work (e.g. it explicitly sets __structuredAttrs = false;), so my fix is also a workaround for now, hopefully things can be set up to work more ergonomically later.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 25, 2026
@mjoerg mjoerg closed this Feb 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants